refactor: use buffer/ package to be compatible with browsers

packages/devices/package.json

@@ -26,6 +26,7 @@
   "dependencies": {
     "@ledgerhq/errors": "^6.10.0",
     "@ledgerhq/logs": "^6.10.0",
+    "buffer": "^6.0.3",
     "rxjs": "6",
     "semver": "^7.3.5"
   },

packages/devices/src/ble/receiveAPDU.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { TransportError, DisconnectedDevice } from "@ledgerhq/errors";
 import { Observable } from "rxjs";
 import { log } from "@ledgerhq/logs";

packages/devices/src/ble/sendAPDU.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { Observable } from "rxjs";
 import { log } from "@ledgerhq/logs";
 const TagId = 0x05;

packages/devices/src/hid-framing.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { TransportError } from "@ledgerhq/errors";
 export type ResponseAcc =
   | {

packages/devices/src/scrambling.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 export function wrapApdu(apdu: Buffer, key: Buffer) {
   if (apdu.length === 0) return apdu;
   const result = Buffer.alloc(apdu.length);

packages/hw-app-algorand/package.json

@@ -30,6 +30,7 @@
     "@ledgerhq/errors": "^6.10.0",
     "@ledgerhq/hw-transport": "^6.11.2",
     "bip32-path": "^0.4.2",
+    "buffer": "^6.0.3",
     "hi-base32": "^0.5.1",
     "js-sha512": "^0.8.0",
     "tweetnacl": "^1.0.3"

packages/hw-app-algorand/src/Algorand.ts

@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ********************************************************************************/
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import BIPPath from "bip32-path";
 import { UserRefusedOnDevice } from "@ledgerhq/errors";

packages/hw-app-btc/package.json

@@ -32,6 +32,7 @@
     "bip32-path": "^0.4.2",
     "bitcoinjs-lib": "^5.2.0",
     "bs58": "^4.0.1",
+    "buffer": "^6.0.3",
     "invariant": "^2.2.4",
     "ripemd160": "2",
     "semver": "^7.3.5",

packages/hw-app-btc/src/Btc.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import { pathStringToArray } from "./bip32";
 import BtcNew, { canSupportApp } from "./BtcNew";
@@ -129,11 +130,11 @@ export default class Btc {
         !isPathNormal(path)
       ) {
         console.warn(`WARNING: Using deprecated device protocol to get the public key because
-        
+
         * a non-standard path is requested, and
         * verify flag is false
-        
-        The new protocol only allows export of non-standard paths if the 
+
+        The new protocol only allows export of non-standard paths if the
         verify flag is true. Standard paths are (currently):
 
         M/44'/(1|0)'/X'
@@ -142,9 +143,9 @@ export default class Btc {
         M/86'/(1|0)'/X'
         M/48'/(1|0)'/X'/Y'
 
-        followed by "", "(0|1)", or "(0|1)/b", where a and b are 
+        followed by "", "(0|1)", or "(0|1)/b", where a and b are
         non-hardened. For example, the following paths are standard
-        
+
         M/48'/1'/99'/7'
         M/86'/1'/99'/0
         M/48'/0'/99'/7'/1/17

packages/hw-app-btc/src/BtcNew.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { crypto } from "bitcoinjs-lib";
 import semver from "semver";
 import { pointCompress } from "tiny-secp256k1";

packages/hw-app-btc/src/BtcOld.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import bs58 from "bs58";
 import RIPEMD160 from "ripemd160";
 import sha from "sha.js";

packages/hw-app-btc/src/bip32.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import bippath from "bip32-path";
 import bs58check from "bs58check";
 

packages/hw-app-btc/src/buffertools.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import varuint from "varuint-bitcoin";
 
 export function unsafeTo64bitLE(n: number): Buffer {

packages/hw-app-btc/src/compressPublicKey.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 export function compressPublicKey(publicKey: Buffer): Buffer {
   const prefix = (publicKey[64] & 1) !== 0 ? 0x03 : 0x02;
   const prefixBuffer = Buffer.alloc(1);

packages/hw-app-btc/src/createTransaction.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { log } from "@ledgerhq/logs";
 import type Transport from "@ledgerhq/hw-transport";
 import { hashPublicKey } from "./hashPublicKey";

packages/hw-app-btc/src/getTrustedInput.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import invariant from "invariant";
 import type Transport from "@ledgerhq/hw-transport";
 import type { Transaction } from "./types";

packages/hw-app-btc/src/getTrustedInputBIP143.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import Transport from "@ledgerhq/hw-transport";
 import shajs from "sha.js";
 import type { Transaction } from "./types";

packages/hw-app-btc/src/newops/accounttype.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { crypto } from "bitcoinjs-lib";
 import { pointAddScalar } from "tiny-secp256k1";
 import { BufferWriter } from "../buffertools";

packages/hw-app-btc/src/newops/appClient.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import Transport from "@ledgerhq/hw-transport";
 import { pathElementsToBuffer } from "../bip32";
 import { PsbtV2 } from "./psbtv2";

packages/hw-app-btc/src/newops/clientCommands.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { crypto } from "bitcoinjs-lib";
 import { BufferReader } from "../buffertools";
 import { createVarint } from "../varint";

packages/hw-app-btc/src/newops/merkelizedPsbt.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { MerkleMap } from "./merkleMap";
 import { PsbtV2 } from "./psbtv2";
 

packages/hw-app-btc/src/newops/merkle.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { crypto } from "bitcoinjs-lib";
 
 /**

packages/hw-app-btc/src/newops/merkleMap.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { createVarint } from "../varint";
 import { hashLeaf, Merkle } from "./merkle";
 

packages/hw-app-btc/src/newops/policy.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { crypto } from "bitcoinjs-lib";
 import { pathArrayToString } from "../bip32";
 import { BufferWriter } from "../buffertools";

packages/hw-app-btc/src/newops/psbtExtractor.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { BufferWriter } from "../buffertools";
 import { PsbtV2 } from "./psbtv2";
 

packages/hw-app-btc/src/newops/psbtFinalizer.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { BufferWriter } from "../buffertools";
 import { psbtIn, PsbtV2 } from "./psbtv2";
 

packages/hw-app-btc/src/newops/psbtv2.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
 /* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 import {

packages/hw-app-btc/src/serializeTransaction.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type { Transaction } from "./types";
 import { createVarint } from "./varint";
 

packages/hw-app-btc/src/signMessage.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import bippath from "bip32-path";
 import { MAX_SCRIPT_BLOCK } from "./constants";

packages/hw-app-btc/src/signP2SHTransaction.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import { getTrustedInput } from "./getTrustedInput";
 import { startUntrustedHashTransactionInput } from "./startUntrustedHashTransactionInput";

packages/hw-app-btc/src/signTransaction.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import { bip32asBuffer } from "./bip32";
 export function signTransaction(

packages/hw-app-btc/src/splitTransaction.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import { log } from "@ledgerhq/logs";
 import type { Transaction, TransactionInput, TransactionOutput } from "./types";
 import { getVarint } from "./varint";

packages/hw-app-btc/src/startUntrustedHashTransactionInput.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import type { Transaction } from "./types";
 import { createVarint } from "./varint";

packages/hw-app-btc/src/varint.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 export function getVarint(data: Buffer, offset: number): [number, number] {
   if (data[offset] < 0xfd) {
     return [data[offset], 1];

packages/hw-app-cosmos/package.json

@@ -29,7 +29,8 @@
   "dependencies": {
     "@ledgerhq/errors": "^6.10.0",
     "@ledgerhq/hw-transport": "^6.11.2",
-    "bip32-path": "^0.4.2"
+    "bip32-path": "^0.4.2",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-app-cosmos/src/Cosmos.ts

@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ********************************************************************************/
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import BIPPath from "bip32-path";
 import { UserRefusedOnDevice } from "@ledgerhq/errors";

packages/hw-app-elrond/package.json

@@ -29,7 +29,8 @@
   "dependencies": {
     "@ledgerhq/errors": "^6.10.0",
     "@ledgerhq/hw-transport": "^6.11.2",
-    "bip32-path": "^0.4.2"
+    "bip32-path": "^0.4.2",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-app-elrond/src/Elrond.ts

@@ -1,5 +1,6 @@
 //@flow
 
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import BIPPath from "bip32-path";
 

packages/hw-app-eth/package.json

@@ -33,6 +33,7 @@
     "@ledgerhq/logs": "^6.10.0",
     "axios": "^0.24.0",
     "bignumber.js": "^9.0.1",
+    "buffer": "^6.0.3",
     "ethers": "^5.5.1"
   },
   "scripts": {

packages/hw-app-eth/src/Eth.ts

@@ -16,6 +16,7 @@
  ********************************************************************************/
 // FIXME drop:
 import { splitPath, foreach } from "./utils";
+import { Buffer } from "buffer/";
 import { log } from "@ledgerhq/logs";
 import { EthAppPleaseEnableContractData } from "@ledgerhq/errors";
 import type Transport from "@ledgerhq/hw-transport";

packages/hw-app-eth/src/erc20.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import blob from "@ledgerhq/cryptoassets/data/erc20-signatures";
 
 /**

packages/hw-app-eth/src/nfts.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import axios from "axios";
 import { getLoadConfig } from "./loadConfig";
 import type { LoadConfig } from "./loadConfig";

packages/hw-app-polkadot/package.json

@@ -29,7 +29,8 @@
   "dependencies": {
     "@ledgerhq/errors": "^6.10.0",
     "@ledgerhq/hw-transport": "^6.11.2",
-    "bip32-path": "^0.4.2"
+    "bip32-path": "^0.4.2",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-app-polkadot/src/Polkadot.ts

@@ -15,6 +15,7 @@
  *  limitations under the License.
  ********************************************************************************/
 import type Transport from "@ledgerhq/hw-transport";
+import { Buffer } from "buffer/";
 import BIPPath from "bip32-path";
 import {
   UserRefusedOnDevice,

packages/hw-app-str/package.json

@@ -29,6 +29,7 @@
   "dependencies": {
     "@ledgerhq/hw-transport": "^6.11.2",
     "base32.js": "^0.1.0",
+    "buffer": "^6.0.3",
     "sha.js": "^2.3.6",
     "tweetnacl": "^1.0.3"
   },

packages/hw-app-str/src/Str.ts

@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ********************************************************************************/
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import {
   splitPath,

packages/hw-app-str/src/utils.ts

@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ********************************************************************************/
+import { Buffer } from "buffer/";
 import base32 from "base32.js";
 import nacl from "tweetnacl";
 import { sha256 } from "sha.js";

packages/hw-app-tezos/package.json

@@ -30,6 +30,7 @@
     "@ledgerhq/hw-transport": "^6.11.2",
     "blake2b": "^2.1.3",
     "bs58check": "^2.1.2",
+    "buffer": "^6.0.3",
     "invariant": "^2.2.4"
   },
   "scripts": {

packages/hw-app-tezos/src/Tezos.ts

@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ********************************************************************************/
+import { Buffer } from "buffer/";
 import invariant from "invariant";
 import bs58check from "bs58check";
 import blake2b from "blake2b";

packages/hw-app-trx/package.json

@@ -28,7 +28,8 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@ledgerhq/errors": "^6.10.0",
-    "@ledgerhq/hw-transport": "^6.11.2"
+    "@ledgerhq/hw-transport": "^6.11.2",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-app-trx/src/Trx.ts

@@ -18,6 +18,7 @@
 import { splitPath, foreach, decodeVarint } from "./utils";
 //import { StatusCodes, TransportStatusError } from "@ledgerhq/errors";
 import type Transport from "@ledgerhq/hw-transport";
+import { Buffer } from "buffer/";
 
 const remapTransactionRelatedErrors = (e) => {
   if (e && e.statusCode === 0x6a80) {

packages/hw-app-xrp/package.json

@@ -28,7 +28,8 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@ledgerhq/hw-transport": "^6.11.2",
-    "bip32-path": "0.4.2"
+    "bip32-path": "0.4.2",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-app-xrp/src/Xrp.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import type Transport from "@ledgerhq/hw-transport";
 import BIPPath from "bip32-path";
 /**

packages/hw-transport-http/package.json

@@ -31,6 +31,7 @@
     "@ledgerhq/hw-transport": "^6.11.2",
     "@ledgerhq/logs": "^6.10.0",
     "axios": "^0.24.0",
+    "buffer": "^6.0.3",
     "ws": "7"
   },
   "scripts": {

packages/hw-transport-http/src/HttpTransport.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import Transport from "@ledgerhq/hw-transport";
 import { TransportError } from "@ledgerhq/errors";
 import axios from "axios";

packages/hw-transport-http/src/WebSocketTransport.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 import Transport from "@ledgerhq/hw-transport";
 import { TransportError } from "@ledgerhq/errors";
 import { log } from "@ledgerhq/logs";

packages/hw-transport-mocker/package.json

@@ -26,7 +26,8 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@ledgerhq/hw-transport": "^6.11.2",
-    "@ledgerhq/logs": "^6.10.0"
+    "@ledgerhq/logs": "^6.10.0",
+    "buffer": "^6.0.3"
   },
   "scripts": {
     "clean": "bash ../../script/clean.sh",

packages/hw-transport-mocker/src/RecordStore.ts

@@ -1,3 +1,4 @@
+import { Buffer } from "buffer/";
 /**
  * thrown by the RecordStore.fromString parser.
  */