Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubble Menu is cut off behind editor perimeter #118

Closed
isv9 opened this issue Jun 17, 2020 · 4 comments
Closed

Bubble Menu is cut off behind editor perimeter #118

isv9 opened this issue Jun 17, 2020 · 4 comments
Labels
improvement released

Comments

@isv9
Copy link

isv9 commented Jun 17, 2020

Hi, I have trouble with the bubble menu. It is cut off behind editor perimeter. I saw #98 and I use element-tiptap v1.24.2 but the bubble menu is cut. The editor-menu-bubble component has a keepInBounds property and if I change keep-in-bounds on true in source element-tiptap the bubble menu won’t be cut. Can we add property keep-in-bounds or advise another solution? Thanks

Снимок экрана 2020-06-17 в 16 40 55
@yoramdelangen
Copy link

I think this is related to #98

@Leecason
Copy link
Owner

I saw such a problem, will fix it.

Leecason pushed a commit that referenced this issue Jun 28, 2020
@semantic-release-bot
chore(release): 1.24.5 [skip ci]
cfd4f9e 
## [1.24.5](https://github.com/Leecason/element-tiptap/compare/@[email protected]) (2020-06-28)

### Bug Fixes

* 🐛 add menuBubbleOptions prop to temporary fix bubble menu cut-off (#118) ([aec41ea](aec41ea))
* update i18n/ru locale ([cb364b8](cb364b8))
@Leecason
Copy link
Owner

I remove the option keep-in-bounds: false in menu-bubble, and add menuBubbleOptions prop to config this.
This is a temporary fix, and I'll improve it with popper.js later.

@Leecason
Copy link
Owner

🎉 This issue has been resolved in version 1.24.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 8, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yoramdelangen @Leecason @isv9