Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #108 영수증 사용처 추가 #108

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

hyxklee
Copy link
Member

@hyxklee hyxklee commented Jan 14, 2025

PR 내용

  • 영수증 DB에 source. 사용처 컬럼을 추가했습니다

PR 세부사항

  • 엔티티에 변수를 추가하고, 생성, 수정, 조회시 사용되는 dto에 동일한 변수명으로 추가했습니다
  • 동일한 변수명을 사용했기에 mapper에 별도 매핑을 해주지 않았습니다
  • 마찬가지로 필수값은 아니라 판단해 선택적으로 입력할 수 있도록 했습니다

관련 스크린샷

image

주의사항

x

체크 리스트

  • 리뷰어 설정
  • Assignee 설정
  • Label 설정
  • 제목 양식 맞췄나요? (ex. #0 Feat: 기능 추가)
  • 변경 사항에 대한 테스트

@hyxklee hyxklee self-assigned this Jan 14, 2025
@hyxklee hyxklee linked an issue Jan 14, 2025 that may be closed by this pull request
@hyxklee hyxklee requested review from huncozyboy and removed request for huncozyboy and KoungQ January 14, 2025 07:12
Comment on lines +14 to +21
Long id,
String description,
String source,
Integer amount,
LocalDate date,
List<FileResponse> fileUrls
) {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !
간단한 DTO만 수정된 것으로 보여서 바로 승인하도록 하겠습니다

Copy link
Collaborator

@jj0526 jj0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~!

@hyxklee hyxklee merged commit bd631bc into develop Jan 18, 2025
2 checks passed
@hyxklee hyxklee deleted the feat/#107/회비-사용처-추가 branch January 18, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat #107 회비 엔티티 사용처 컬럼 추가
3 participants