Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat #115 멤버 조회 #115

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Feat #115 멤버 조회 #115

merged 5 commits into from
Feb 2, 2025

Conversation

hyxklee
Copy link
Member

@hyxklee hyxklee commented Jan 31, 2025

PR 내용

  • 기수별 멤버 조회와 멤버 검색 API를 구현했습니다.
  • 기수 조회는 1개 api에서 cardinal의 유무로 전체 조회, 기수별 조회를 할 수 있도록 했습니다
  • 검색 API는 jpa의 containing 메서드를 이용해 db like 연산으로 검색어에 포함된 데이터를 리스트로 반환하도록 했습니다

PR 세부사항

  • find나 info를 가져오는 경우 cardinals가 매핑이 안되는 문제를 발견해 변수명 통일로 수정해줬습니다

관련 스크린샷

image image

주의사항


체크 리스트

  • 리뷰어 설정
  • Assignee 설정
  • Label 설정
  • 제목 양식 맞췄나요? (ex. #0 Feat: 기능 추가)
  • 변경 사항에 대한 테스트

@hyxklee hyxklee requested review from jj0526 and huncozyboy January 31, 2025 10:21
@hyxklee hyxklee self-assigned this Jan 31, 2025
@hyxklee hyxklee linked an issue Jan 31, 2025 that may be closed by this pull request
Feat #114 멤버 조회시 기수별 조회 멤버 검색 API 구현 #114
Closed
@hyxklee hyxklee changed the title Feat #114 멤버 조회 Feat #115 멤버 조회 Jan 31, 2025
huncozyboy
huncozyboy approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@huncozyboy huncozyboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

로직상 문제는 없어보여서, 따로 리뷰할만한 내용은 없었습니당

jj0526
jj0526 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@jj0526 jj0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저 이름을 사용해 조회하는 경우 ㄱ과 같은 글자도 따로 조회가 되나요?
일단 로직상으로는 문제 없어보여요!

@hyxklee hyxklee merged commit 030e4f0 into develop Feb 2, 2025
2 checks passed
@hyxklee hyxklee deleted the feat/#114/멤버-조회 branch February 2, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj0526 jj0526 jj0526 approved these changes

@huncozyboy huncozyboy huncozyboy approved these changes

Assignees

@hyxklee hyxklee

Labels
feature refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat #114 멤버 조회시 기수별 조회 멤버 검색 API 구현
3 participants
@hyxklee @jj0526 @huncozyboy