Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huncozyboy
reviewed
Jan 31, 2025
| return CommonResponse.createSuccess(EVENT_UPDATE_SUCCESS.getMessage()); | ||
| } | ||
|
|
||
| @DeleteMapping("/{eventId}") | ||
| @Operation(summary="일정 삭제") | ||
| @Operation(summary = "일정 삭제") | ||
| public CommonResponse<Void> delete(@PathVariable Long eventId) { | ||
| eventUseCase.delete(eventId); |
There was a problem hiding this comment.
일정과 정기모임을 생성이랑 수정해주는건 단일 API고
삭제는 type을 받지않고, 개별 API로 처리해주신건 의도된 설계인거죠 ??
Comment on lines
+44
to
+48
| if (dto.type() == Type.EVENT) { | ||
| eventUseCase.update(eventId, dto, userId); | ||
| } else { | ||
| meetingUseCase.update(dto, userId, eventId); | ||
| } |
There was a problem hiding this comment.
type을 체크해줘서 일정이랑 정기모임별로 생성 및 수정이 가능하도록 개선한 내용이네용 👍🏻
| public Map<Integer, List<Response>> findByYearly(LocalDateTime start, LocalDateTime end) { | ||
| List<Response> events = eventGetService.find(start, end); | ||
| List<Response> meetings = meetingGetService.find(start, end); | ||
| public Map<Integer, List<Response>> findByYearly(Integer year, Integer semester) { |
There was a problem hiding this comment.
해당 부분에서 일정 조회할때 연도랑 학기 단위로 조회 가능하도록 변경된거 또한 확인했습니다 !
jj0526
approved these changes
Feb 1, 2025
| @Parameter(hidden = true) @CurrentUser Long userId) { | ||
| eventUseCase.save(dto, userId); | ||
| if (dto.type() == Type.EVENT) { |
There was a problem hiding this comment.
dto에서 타입을 받아 경우에 따라 저장하는거 확인했습니다!
| @NotBlank String content, | ||
| @NotBlank String location, | ||
| @NotBlank String requiredItem, | ||
| @NotNull Type type, |
There was a problem hiding this comment.
수정도 한 API에서 진행을 해서 기존 type을 그대로 받아서 확인을 통해 event인지 meeting인지 구분 해줘야한다고 판단했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
PR 세부사항
관련 스크린샷
주의사항
체크 리스트