Ignore abstract classes in strict mocking PHPStan rule (#14)

Lendable · Dec 2, 2023 · 994f17d · 994f17d
1 parent 8e678d7
commit 994f17d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/src/Phpstan/Rule/EnforceStrictMocking.php b/src/Phpstan/Rule/EnforceStrictMocking.php
@@ -48,6 +48,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($node->isAbstract()) {
+            return [];
+        }
+
         $className = $node->namespacedName->toString();
         if (!\str_ends_with($className, 'Test')) {
             return [];

diff --git a/tests/phpstan/Rule/EnforceExtendedClassTest.php b/tests/phpstan/Rule/EnforceExtendedClassTest.php
@@ -27,6 +27,12 @@ public function reports_test_directly_extending_phpunits_test_case(): void
         ]);
     }
 
+    #[Test]
+    public function does_not_report_abstract_test_directly_extending_phpunits_test_case(): void
+    {
+        $this->analyse([__DIR__.'/../data/AbstractTestCaseTest.php'], []);
+    }
+
     #[Test]
     public function reports_test_indirectly_extending_phpunits_test_case(): void
     {

diff --git a/tests/phpstan/data/AbstractTestCaseTest.php b/tests/phpstan/data/AbstractTestCaseTest.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Phpstan\Lendable\PHPUnitExtensions\data;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractTestCaseTest extends TestCase {}
-Original file line number
+Diff line change
@@ Expand Up @@
             ]);
         }
+        #[Test]
+        public function does_not_report_abstract_test_directly_extending_phpunits_test_case(): void
+        {
+            $this->analyse([__DIR__.'/../data/AbstractTestCaseTest.php'], []);
+        }
         #[Test]
         public function reports_test_indirectly_extending_phpunits_test_case(): void
         {
@@ Expand Down @@