Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line mode flag #17

Closed
wants to merge 2 commits into from
Closed

Conversation

mtabini
Copy link

@mtabini mtabini commented Feb 19, 2022

Hello! In my application, I needed to receive each character from the client individually, and so I implemented a new flag called lineMode (off by default for backwards compatibility). I figured this might be handy for others, so I thought I'd send in a PR for it. Cheers!

@LennartHennigs
Copy link
Owner

Hey,
Thank you for the PR. Yes, that's a good point. Will test it and merge it.
But I'll rename the set function to be a setLineMode() or enableLineMode(). Something along those lines.

Cheers
L.

LennartHennigs added a commit that referenced this pull request Mar 3, 2022
@LennartHennigs
Copy link
Owner

LennartHennigs commented Mar 3, 2022

Hey,
pushed code in the latest update. Thank you. Due to conflicts in the current code and due to my lack of github skills I did add the code manually and will close this branch.

Cheers
l.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants