Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the newline character configurable #69

Merged

Conversation

FunDeckHermit
Copy link
Contributor

In my application the newline isn't '\n' and maybe there are some other people who have the same requirement.

When okay'ed I'll also add these functions to the Readme.

I'm not used to making Pull Requests, please tell me if I'm doing something wrong.

@LennartHennigs
Copy link
Owner

Hey.
Thank your for the PR.
I think that is this a decent addition. Yes, feel free to update the Readme and the channelog.

I can merge that later using your PR and branch.
Cheers

@FunDeckHermit
Copy link
Contributor Author

I've modified the Readme and also took the liberty to expand some if it.
Do you prefer setNewLineCharacter or setNewlineCharacter (lowercase L) ?

@LennartHennigs
Copy link
Owner

Thank you.
I appreciate this.
Newline

@FunDeckHermit
Copy link
Contributor Author

Hi Lennart,

It should be ready for review and merging!

@FunDeckHermit
Copy link
Contributor Author

Hi Lennart,

Could you approve the PR and make a new release?

@LennartHennigs LennartHennigs self-assigned this Oct 3, 2024
@LennartHennigs LennartHennigs changed the base branch from main to 69-configurable-newline October 3, 2024 06:43
@LennartHennigs LennartHennigs merged commit 8f8de89 into LennartHennigs:69-configurable-newline Oct 3, 2024
@LennartHennigs
Copy link
Owner

Hey Roy,
thanks again. Just merger your PR and some other small update.
It's now part of 2.2.2.

Cheers
l.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants