Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Swift 4 / Xcode 9.1 ; String / Substring API #67

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Swift 4 / Xcode 9.1 ; String / Substring API #67

merged 1 commit into from
Nov 9, 2017

Conversation

saj4high2n
Copy link
Contributor

Updated

  1. Updated to Swift 4.02 with Xcode 9.1

  2. String / Substring API

    • Change .characters.count to .count
    • Replace substring(with:) with subscripting syntax

  3. Rewrite NSAttributedString's attributedOptions

  4. Rewrite extractBaseUrl(_ url: String) -> String with String API's split method

@ghost
Copy link

ghost commented Nov 8, 2017

1 Error
🚫 Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@LeonardoCardoso
Copy link
Owner

Thanks, @saj4high2n.

@LeonardoCardoso LeonardoCardoso merged commit 2bb26eb into LeonardoCardoso:master Nov 9, 2017
@saj4high2n saj4high2n deleted the to_swift4 branch November 10, 2017 05:41
@LeonardoCardoso
Copy link
Owner

Close #80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saj4high2n @LeonardoCardoso