Make read_lines arguments positional too

lib/File/Slurper.pm

@@ -73,15 +73,15 @@ sub write_binary {
 }
 
 sub read_lines {
-	my ($filename, $encoding, %options) = @_;
+	my ($filename, $encoding, $crlf, $skip_chomp) = @_;
 	$encoding ||= 'utf-8';
-	my $layer = _text_layers($encoding, $options{crlf});
+	my $layer = _text_layers($encoding, $crlf);
 
 	open my $fh, "<$layer", $filename or croak "Couldn't open $filename: $!";
-	return <$fh> if not %options;
+	return <$fh> if $skip_chomp;
 	my @buf = <$fh>;
 	close $fh;
-	chomp @buf if $options{chomp};
+	chomp @buf;
 	return @buf;
 }
 
@@ -114,17 +114,9 @@ Reads file C<$filename> into a scalar and decodes it from C<$encoding> (which de
 
 Reads file C<$filename> into a scalar without any decoding or transformation.
 
-=func read_lines($filename, $encoding, %options)
-
-Reads file C<$filename> into a list/array after decoding from C<$encoding>. By default it returns this list. Can optionally take this named argument:
-
-=over 4
+=func read_lines($filename, $encoding, $crlf, $skip_chomp)
 
-=item * chomp
-
-C<chomp> the lines.
-
-=back
+Reads file C<$filename> into a list/array line-by-line, after decoding from C<$encoding>, optional crlf translation and chomping.
 
 =func write_text($filename, $content, $encoding, $crlf)
 

t/10-basics.t

@@ -15,9 +15,10 @@ is(read_binary($0), $content, 'read_binary() works');
 
 my @content = split /(?<=\n)/, $content;
 
-is_deeply([ read_lines($0) ], \@content, 'read_lines returns the right thing');
+is_deeply([ read_lines($0, 'utf-8', 0, 1) ], \@content, 'read_lines returns the right thing (no chomp)');
 chomp @content;
-is_deeply([ read_lines($0, 'utf-8', chomp => 1) ], \@content, 'read_lines(chomp => 1) returns the right thing');
+
+is_deeply([ read_lines($0) ], \@content, 'read_lines returns the right thing (chomp)');
 
 is_deeply([ read_dir('lib') ], [ 'File' ], 'read_dir appears to work');