Allow to read new format="4.0" as a float #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fonttools/fonttools@ceb41ec (still unreleased), @LettError changed the designspace document "format" field from an integer "3" to a float "4.0".
Using mutatorMath DesignSpaceDocumentReader with a designspace file that was generated by the new fontTools.designspaceLib (with format "4.0"), currently throws a ValueError.
GlyphsLib uses fonttools.designspaceLib to create designspace documents, and fontmake (still) uses mutatorMath for instantiating UFOs.
I undersand we want to move away from relying on mutatorMath's own UFO processing (#113) in favour of ufoProcessor. However, we need some time before we can update fontmake to use that. And before then we need to be able to release the new fonttools without breaking fontmake because of mutatorMath..
This patch allows to read in a 4.0 designspace document without the error. Note that the only new feature added to 4.0 is the conditionset elements in the rules, but mutatorMath itself does not read the rules elements, so this change should be innocuous.
PTAL, thanks.