hw8 #123
Open
hw8 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshimber
commented
Aug 9, 2023
| // templateUpdated2$: BehaviorSubject<TemplateRef<unknown> | null> = new BehaviorSubject(null); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| openPopup(template: TemplateRef<unknown>, context?: any): void { |
There was a problem hiding this comment.
вернулась из отпусков снова тупить)
не понимаю, зачем контекст и откуда брать его. типа this ?
может, упустила что-то из лекции
| providedIn: 'root', | ||
| }) | ||
| export class PopupService { | ||
| templateUpdated$: Subject<TemplateRef<unknown> | null> = new Subject(); |
There was a problem hiding this comment.
почему бех-сабжект гнусно себя ведет и не дает записать как в закомменченной строчке? ну можт я доберусь таки до Вас для сессии с вопросами, 4 лекции осталось)
There was a problem hiding this comment.
посмотрела вашу версию хомворка, поняла про сабж, а также в очередной раз поняла, как всё плохо. вот мое решение, работает же кое-как. а вот как можно написать - в 100 раз сложнее и умнее. не понимаю, как к этому придти самой( хочется в проект, где люди так пишут, а попадаю в болота какие-то)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.