Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Remove non-standard raw option #65

Closed
vweevers opened this issue May 23, 2018 · 3 comments · Fixed by #83
Closed

Remove non-standard raw option #65

vweevers opened this issue May 23, 2018 · 3 comments · Fixed by #83
Labels
upgrade guide Improvements or additions to upgrade guide(s)
Milestone
v3

Comments

@vweevers
Copy link
Member

https://github.com/Level/level.js/blob/e819338e87aa305e57ec9c2fe58168ab5dca6da3/index.js#L47-L53
@vweevers vweevers added this to the v3 milestone May 23, 2018
@ralphtheninja ralphtheninja added the upgrade guide Improvements or additions to upgrade guide(s) label May 23, 2018
@vweevers
Copy link
Member Author

@ralphtheninja the idea of the upgrading label is to remember breaking changes?

@ralphtheninja
Copy link
Member

@vweevers Exactly!

@vweevers
Copy link
Member Author

In UPGRADING.md we can mention the id encoding, which is the "idiomatic" way to do what raw does here.

vweevers added a commit that referenced this issue May 24, 2018
@vweevers
remove options.raw (#65)
d368727
@vweevers vweevers mentioned this issue May 24, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upgrade guide Improvements or additions to upgrade guide(s)
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

Upgrade Level/level-js
2 participants
@ralphtheninja @vweevers