Abstract tests single function (#495)

* Target abstract-leveldown#ffba12f * Use single test function from abstract-leveldown * Target abstract-leveldown#d7411bb * Options is actually now passed as options from abstract-leveldown and not a function
Level · Jul 13, 2018 · 86d97f5 · 86d97f5
1 parent 85ad5de
commit 86d97f5
Show file tree

Hide file tree

Showing 15 changed files with 10 additions and 66 deletions.
diff --git a/chained-batch.js b/chained-batch.js
@@ -19,7 +19,7 @@ ChainedBatch.prototype._clear = function (key) {
 }
 
 ChainedBatch.prototype._write = function (options, callback) {
-  this.binding.write(options, callback)
+  this.binding.write(callback)
 }
 
 util.inherits(ChainedBatch, AbstractChainedBatch)

diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
   ],
   "main": "leveldown.js",
   "dependencies": {
-    "abstract-leveldown": "level/abstract-leveldown#master",
+    "abstract-leveldown": "level/abstract-leveldown#d7411bb",
     "bindings": "~1.3.0",
     "fast-future": "~1.0.2",
     "nan": "~2.10.0",

diff --git a/test/abstract-leveldown-test.js b/test/abstract-leveldown-test.js
@@ -0,0 +1 @@
+require('abstract-leveldown/test')(require('./common'))
diff --git a/test/batch-test.js b/test/batch-test.js
diff --git a/test/chained-batch-test.js b/test/chained-batch-test.js
diff --git a/test/close-test.js b/test/close-test.js
diff --git a/test/common.js b/test/common.js
@@ -1,9 +1,10 @@
-const testCommon = require('abstract-leveldown/test/common')
+const test = require('tape')
 const tempy = require('tempy')
 const leveldown = require('..')
 
-testCommon.factory = function () {
-  return leveldown(tempy.directory())
-}
-
-module.exports = testCommon
+module.exports = require('abstract-leveldown/test/common')({
+  test: test,
+  factory: function () {
+    return leveldown(tempy.directory())
+  }
+})
diff --git a/test/del-test.js b/test/del-test.js
diff --git a/test/get-test.js b/test/get-test.js
diff --git a/test/iterator-range-test.js b/test/iterator-range-test.js
diff --git a/test/iterator-test.js b/test/iterator-test.js
@@ -1,13 +1,8 @@
-const test = require('tape')
-const testCommon = require('./common')
-const abstract = require('abstract-leveldown/test/iterator-test')
 const make = require('./make')
 const iota = require('iota-array')
 const lexi = require('lexicographic-integer')
 const util = require('util')
 
-abstract.all(testCommon.factory, test)
-
 make('iterator throws if key is not a string or buffer', function (db, t, done) {
   var keys = [null, undefined, 1, true, false]
   var pending = keys.length

diff --git a/test/leveldown-test.js b/test/leveldown-test.js
@@ -1,10 +1,6 @@
 const test = require('tape')
-const testCommon = require('./common')
-const abstract = require('abstract-leveldown/test/leveldown-test')
 const leveldown = require('..')
 
-abstract.args(testCommon.factory, test)
-
 test('test database creation non-string location throws', function (t) {
   t.throws(
     leveldown.bind(null, {}),

diff --git a/test/open-test.js b/test/open-test.js
diff --git a/test/put-get-del-test.js b/test/put-get-del-test.js
diff --git a/test/put-test.js b/test/put-test.js
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		require('abstract-leveldown/test')(require('./common'))