Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #98 问题及优化部分代码 #99

Merged
merged 48 commits into from
Feb 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d2a37e0
Theme: 优化单例实现,初步优化 BrnAllThemeConfig 属性获取不为 null
zhoujuanjuan Dec 27, 2021
75a2be3
refactor:优化theme,暴露非null引用
zhoujuanjuan Dec 27, 2021
f97bf07
theme:去除无用信息及优化部分代码
zhoujuanjuan Dec 28, 2021
44ba17a
theme:增加属性类型
zhoujuanjuan Dec 28, 2021
cad7451
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Dec 31, 2021
c19203f
优化修复 EventBus
zhoujuanjuan Dec 31, 2021
c96cdd3
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 4, 2022
2c99d35
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 4, 2022
c7ae392
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 5, 2022
6e0834b
迁移example ,优化常量命名,增加export
zhoujuanjuan Jan 4, 2022
5db665d
migrate brn_empty_status.dart
zhoujuanjuan Jan 5, 2022
7c12fc8
删除 BrnThemeImg
zhoujuanjuan Jan 6, 2022
0b75394
Merge remote-tracking branch 'upstream/null-safe' into null-safe
zhoujuanjuan Jan 6, 2022
c00cfd5
fix:tagConfig merge方法增加判空处理
zhoujuanjuan Jan 6, 2022
ada5216
fix:revert tagConfig
zhoujuanjuan Jan 7, 2022
beec378
fix:BrnAbnormalStateWidget空处理
zhoujuanjuan Jan 7, 2022
b852eb6
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 7, 2022
e69a944
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 10, 2022
e31532f
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 11, 2022
162fcfe
Migrated tabbar to null-safety
zhoujuanjuan Jan 11, 2022
2bd473f
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 12, 2022
103ab13
Migrated scroll_anchor to null-safety
zhoujuanjuan Jan 11, 2022
2b141fd
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 13, 2022
04b7a3e
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 17, 2022
5748da7
fix:修复迁移tabar问题
zhoujuanjuan Jan 17, 2022
8c25d72
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 18, 2022
1c33fd9
migrate form to null safety
zhoujuanjuan Jan 18, 2022
07c308a
fix:修复tabbar报错及selection警告信息
zhoujuanjuan Jan 18, 2022
fdf45af
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 19, 2022
e1749fe
Merge remote-tracking branch 'upstream/null-safe' into null-safe
zhoujuanjuan Jan 24, 2022
0b4c168
fix:修复迁移问题
zhoujuanjuan Jan 24, 2022
3f3b4d3
fix:优化迁移部分问题key和style非空问题
zhoujuanjuan Jan 24, 2022
1b89f72
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 24, 2022
8b9e3ab
migrate picker to null safety
zhoujuanjuan Jan 24, 2022
fbe085a
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 25, 2022
2d7fcc1
fix:修复picker空安全迁移问题
zhoujuanjuan Jan 25, 2022
a23e201
fix:修复list没指定泛型及if判断错误问题
zhoujuanjuan Jan 26, 2022
4fa42f7
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 26, 2022
33ed04a
fix:migrate dashed line to null safty
zhoujuanjuan Jan 26, 2022
4300e62
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Jan 26, 2022
069436d
migrate example to null safty
zhoujuanjuan Jan 26, 2022
3e28aa4
fix:修复部分example warning
zhoujuanjuan Jan 26, 2022
00f8a47
fix:修复demo报错问题
zhoujuanjuan Jan 27, 2022
8b17ba3
fix:追加未跟踪修复
zhoujuanjuan Jan 27, 2022
a526542
fix:优化部分接口可空参数为非空
zhoujuanjuan Jan 27, 2022
966b63e
Merge branch 'null-safe' into null-safe
violinday Feb 7, 2022
7028763
Merge branch 'LianjiaTech:null-safe' into null-safe
zhoujuanjuan Feb 14, 2022
4c62a0c
fix:修复tabar showmore overflow 问题 #98 以及 tabbar 标签颜色默认设置倒置问题
zhoujuanjuan Feb 16, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/src/components/dialog/brn_scrollable_text_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ class BrnScrollableText extends StatelessWidget {
if (onSubmitClick != null) {
onSubmitClick!();
}
Navigator.pop(context);
},
isShowOperateWidget: isShowOperateWidget,
);
Expand Down
30 changes: 14 additions & 16 deletions lib/src/components/tabbar/normal/brn_tab_bar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import 'package:flutter/rendering.dart';
/// [state]:当前组件的State对象,[BrnTabBarState]
/// [index]:当前组件的角标
typedef BrnTabBarOnTap = Function(BrnTabBarState state, int index);

const double _tagDefaultSize = 75.0;
/// 带小红点的Tabbar
// ignore: must_be_immutable
class BrnTabBar extends StatefulWidget {
Expand Down Expand Up @@ -628,6 +628,7 @@ class BrnTabBarState extends State<BrnTabBar> {
// 更多弹框样式
// ignore: must_be_immutable
class _TabBarOverlayWidget extends StatefulWidget {

List<BadgeTab>? tabs;

String? moreWindowText;
Expand All @@ -637,30 +638,30 @@ class _TabBarOverlayWidget extends StatefulWidget {
BrnTabBarConfig themeData;

/// tag间距
double? spacing;
double spacing;

/// 每行tag数
int? preLineTagCount;
int preLineTagCount;

/// tag高度
double? tagHeight;

_TabBarOverlayWidget(
{this.tabs,
this.moreWindowText,
this.brnTabbarController,
required this.themeData,
this.spacing,
this.preLineTagCount,
this.tagHeight});
this.moreWindowText,
this.brnTabbarController,
required this.themeData,
this.spacing: 12.0,
this.preLineTagCount: 4,
this.tagHeight});

@override
_TabBarOverlayWidgetState createState() => _TabBarOverlayWidgetState();
}

class _TabBarOverlayWidgetState extends State<_TabBarOverlayWidget> {
/// tag宽度
double? _tagWidth;
double _tagWidth = _tagDefaultSize;

double _padding = 20;

Expand Down Expand Up @@ -724,11 +725,8 @@ class _TabBarOverlayWidgetState extends State<_TabBarOverlayWidget> {

Widget _createMoreItems() {
// 计算tag的宽度
_tagWidth = (_parentWidth -
widget.spacing! * (widget.preLineTagCount! - 1) -
_padding * 2) /
widget.preLineTagCount!;

_tagWidth = (_parentWidth - widget.spacing * (widget.preLineTagCount - 1) - _padding * 2) / widget.preLineTagCount;
_tagWidth = _tagWidth <= _tagDefaultSize ? _tagDefaultSize : _tagWidth;
List<Widget> widgets = <Widget>[];
List<BadgeTab>? tabList = widget.tabs;
if (tabList != null && tabList.isNotEmpty) {
Expand All @@ -738,7 +736,7 @@ class _TabBarOverlayWidgetState extends State<_TabBarOverlayWidget> {
}
}
return Wrap(
spacing: widget.spacing!,
spacing: widget.spacing,
runSpacing: 12,
children: widgets,
);
Expand Down
4 changes: 2 additions & 2 deletions lib/src/components/text/brn_expandable_text.dart
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class _BrnExpandableTextState extends State<BrnExpandableText> {
ellipsis: 'EllipseText');
tp.layout(maxWidth: size.maxWidth);
if (tp.didExceedMaxLines) {
if (this._expanded!) {
if (this._expanded) {
return _expandedText(context, widget.text);
} else {
return _foldedText(context, widget.text);
Expand Down Expand Up @@ -133,7 +133,7 @@ class _BrnExpandableTextState extends State<BrnExpandableText> {
setState(() {
_expanded = true;
if (null != widget.onExpanded) {
widget.onExpanded!(_expanded!);
widget.onExpanded!(_expanded);
}
});
},
Expand Down
4 changes: 2 additions & 2 deletions lib/src/theme/base/brn_default_config_utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -596,12 +596,12 @@ class BrnDefaultConfigUtils {
color: defaultCommonConfig.colorTextBase,
fontSize: defaultCommonConfig.fontSizeCaption,
),
tagNormalBgColor: defaultCommonConfig.brandPrimary.withAlpha(0x14),
tagNormalBgColor: defaultCommonConfig.fillBody,
tagSelectedTextStyle: BrnTextStyle(
color: defaultCommonConfig.brandPrimary,
fontSize: defaultCommonConfig.fontSizeCaption,
),
tagSelectedBgColor: defaultCommonConfig.fillBody,
tagSelectedBgColor: defaultCommonConfig.brandPrimary.withAlpha(0x14),
tagSpacing: 12.0,
preLineTagCount: 4,
tagHeight: 32.0,
Expand Down
1 change: 0 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies:
photo_view: ^0.13.0
provider: ^6.0.1
badges: ^2.0.2
collection: ^1.15.0

dev_dependencies:
flutter_test:
Expand Down