Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for xinput mouse w/ pipeinput uinput kb. Closes #194 #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rbreaves
Copy link
Contributor

Not ready for merging just yet as this needs to be a parameterized option for the user to decide if they want complete pipeinput for all devices or pipeinput for some except for the mouse and scrolling, which can be pushed over to x11.

@rbreaves
Copy link
Contributor Author

rbreaves commented Sep 5, 2022

I believe this is now ready for merging, but please review. Added this as an option referred to as UINPUTX. I have updated the help and related files as well to document the addition.

ex.

sudo /usr/local/bin/x11vnc -forever -display :0 -auth guess -rfbport 5900 -noxdamage -pipeinput UINPUTX:direct_key=/dev/input/event1,direct_abs=/dev/input/event7 -overlay -repeat -cursor_drag -usepw

If there is a better terminology to use for the mouse input then please make the change or suggestion so I can update it. I assume it is a virtual xinput device related to x11 and is the only way I know to refer to it at the moment.

@rbreaves
Copy link
Contributor Author

@bk138 Are there any additional changes or things you may want done to make this PR acceptable? If adding UINPUTX as a parameter option doesn't gel well with how you would like to see this implemented just let me know.

Perhaps an alternative would be to go use UINPUT but specify xinput_abs vs direct_abs. It just seemed more straight forward to add another input option further up when I was looking at it and avoid making any real changes to the existing UINPUT function.

@bk138
Copy link
Member

bk138 commented Sep 18, 2022

@rbreaves I'll try to have a look ASAP, but my main foucs currently lies with €€€-work and my other open-source projects. In fact, x11vnc has the least priority and is looking for a new maintainer (#186). Let me know if you're interested ;-).

That being said, I can have a look at this but TBH it'll take a while.

@rbreaves
Copy link
Contributor Author

No worries, & I get that. I’ve been somewhat inactive on my OSS projects of late & I rarely follow up on PRs I’ve put out there.

Doubt this addition is anything anyone has been clamoring for - as surprised as I am that someone didn’t need this before me lol. I assume I’m not the first though, just others didn’t bother to dig into it.

Afaik it will mostly just help my Kinto.sh users be able to use any Linux distro remotely w/ macOS like shortcuts & proper mouse/trackpad support. Should also help users of other key remapper software maintain normal mouse support.

Also I appreciate that you merged the Win/Super PR months ago! Not sure how that key got overlooked for uinput mode by the original creator but it was lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants