Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock Merlin MIB DataSet and simulator tests #103

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

matbryan52
Copy link
Member

@matbryan52 matbryan52 commented Apr 26, 2023

Adds generation of a small fake MIB dataset which can run in the simulator and be tested.

Adds a test for passive mode, active mode, and trigger + garbage active mode.

In the future could add tests for raw mode rather than just integer mode, and also add this dataset generation to LiberTEM.

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

@matbryan52 matbryan52 changed the title Add mock merlin ds and sim tests Add mock Merlin MIB DataSet and simulator tests Apr 26, 2023
@matbryan52
Copy link
Member Author

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (014b6d1) 79.39% compared to head (f9f878c) 79.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files          35       35           
  Lines        3382     3382           
  Branches      451      451           
=======================================
  Hits         2685     2685           
+ Misses        563      562    -1     
- Partials      134      135    +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sk1p sk1p added enhancement New feature or request detector:merlin backport:stable PR should be backported to stable branch labels Apr 27, 2023
@matbryan52
Copy link
Member Author

/azp run libertem.libertem-live-data

@LiberTEM LiberTEM deleted a comment from azure-pipelines bot Apr 27, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p sk1p merged commit d798499 into LiberTEM:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:stable PR should be backported to stable branch detector:merlin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants