Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in source tarball #99

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Conversation

matbryan52
Copy link
Member

Include tests in source tarball to allow testing during conda-build

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

@matbryan52 matbryan52 changed the title Sdist tests Include tests in source tarball Apr 24, 2023
@sk1p
Copy link
Member

sk1p commented Apr 24, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (07352b9) 79.39% compared to head (0989153) 79.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   79.39%   79.33%   -0.06%     
==========================================
  Files          35       35              
  Lines        3382     3382              
  Branches      451      451              
==========================================
- Hits         2685     2683       -2     
- Misses        563      564       +1     
- Partials      134      135       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sk1p added 2 commits April 24, 2023 12:08
- s/license_file/license_files/
- Exclude uneccessary .mypy_cache and __pycache__ directories
@sk1p
Copy link
Member

sk1p commented Apr 24, 2023

FYI I pushed into this PR, as the current MANIFEST.in was a bit liberal when choosing what files to include - for example, the v0.2.0 wheel/sdist includes some __pycache__ files, and if I build it from my laptop, it also includes the (quite large) .mypy_cache directory. Tests should still be properly contained in the sdist. Also included two drive-by fixes for correctness.

@sk1p
Copy link
Member

sk1p commented Apr 24, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p sk1p merged commit 23efefd into LiberTEM:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants