Better handling of millis and micros #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
approved these changes
May 12, 2022
enddynayn
approved these changes
May 12, 2022
lib/types.ts
Outdated
| } | ||
| } | ||
|
|
||
| function fromPrimitive_TIMESTAMP_MICROS(value: number | bigint) { | ||
| return typeof value === 'bigint' ? new Date(Number(value / 1000n)): new Date(value / 1000); | ||
| if (value === undefined) return new Date(NaN); |
There was a problem hiding this comment.
Can value be undefined?
There was a problem hiding this comment.
... Checking... Nope! It cannot be (even at runtime). Line 196 of that file catches that. Removing that line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TIMESTAMP_MICROS would not always handle bigint correctly.
From: ZJONSSON#58
Solution
Cleanup the code some
Change summary: