Django 4.2 upgrade #2346
Merged
Django 4.2 upgrade #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go-bittersweet and django_prometheus_metrics have not been updated for Django 4 and so are broken without manually editing the code in those libraries.
…go-bittersweet and django_prometheus_metrics have not been updated for Django 4 and so are broken without manually editing the code in those libraries.
rasarkar
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://staff.loc.gov/tasks/browse/CONCD-676
The code changes on our side are very minor, but the upgrade broke four libraries that never updated for Django 4. It was decided to integrate the code from those libraries directly into Concordia to simplify maintenance of the code.
django-tabular-export and django-bittersweet were released into the public domain, so I've incorporated those directly, removing most of django-bittersweets code because it wasn't used in Concordia.
django-prometheus-metrics and django-passwords were released under licenses that allow the free redistributions and modification of the code so long as the license and copyright notice are included. I've included those in the LICENSE file in the new prometheus-metrics Django app and concordia.passwords module.
I would suggest clearing your virtualenv and reinstalling once you pull in this code. You will likely also need to modify your personal settings file to properly use the STORAGES setting. I changed:
DEFAULT_FILE_STORAGE = "storages.backends.s3boto3.S3Boto3Storage"to
STORAGES = { **STORAGES, "default": { "BACKEND": "storages.backends.s3boto3.S3Boto3Storage", }, }after making sure STORAGES was imported from .settings_template