Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONCD-1007 Still a few issues #2626

Merged
merged 6 commits into from
Dec 6, 2024
+4 −11
Merged

CONCD-1007 Still a few issues #2626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59a2956
CONCD-1007 in a larger browser window, fill the entire screen
rasarkar Dec 4, 2024
26a9781
CONCD-1007 Invert filter slider should be centered
rasarkar Dec 4, 2024
70a77d3
CONCD-1007 Invert filter slider should be on the same vertical line a…
rasarkar Dec 4, 2024
b1844ba
CONCD-1007 trying to fix another issue where the status goes missing
rasarkar Dec 5, 2024
6919963
CONCD-1007 fixing a bug in the previous commit
rasarkar Dec 5, 2024
9569a2f
CONCD-1007 trying to revert our carousel dimensions to what it was (b…
rasarkar Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions concordia/static/js/src/contribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,16 +339,15 @@ function setupPage() {
.done(function (data) {
$('#transcription-status-display')
.children()
.attr('hidden', 'hidden')
.filter('#display-submitted')
.removeAttr('hidden');
.attr('hidden', 'hidden');
let messageChildren = $(
'#transcription-status-display',
).children();
messageChildren
.attr('hidden', 'hidden')
.filter('#message-submitted')
.removeAttr('hidden');
$('#display-submitted').removeAttr('hidden');
messageChildren
.filter('#message-contributors')
.removeAttr('hidden')
Expand Down
8 changes: 1 addition & 7 deletions concordia/static/scss/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,6 @@ $bg-not-started: #fff;
/* stylelint-disable-next-line color-function-notation */
$shadow-color: rgba(51, 51, 51, 80%); /* #333333 */

html {
@include media-breakpoint-up(xl) {
width: 1200px;
}
}

html,
#contribute-main-content {
background-color: $white;
Expand Down Expand Up @@ -1108,7 +1102,7 @@ body .disabled > .page-link {

#homepage-carousel {
@include media-breakpoint-up(xl) {
max-width: 1200px;
max-width: 1140px;
}
}

Expand Down
2 changes: 1 addition & 1 deletion concordia/templates/transcriptions/asset_detail/viewer_filters.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
</form>
</div>
<div id="invert-filter" class="tab-pane pt-2" role="tabpanel" style="background-color: white;">
<form id="invert-form" onsubmit="return false;">
<form id="invert-form" onsubmit="return false;" class="d-flex justify-content-center">
<label class="ms-2 align-middle">Off</label>
<div class="form-check form-switch custom-control-inline ms-1 me-2">
<input type="checkbox" id="invert" name="invert" class="form-check-input" role="switch" />
Expand Down
Loading