QR Code Integration and Bug Fixes, Deps Updates and Refinements for 1.7 2FA #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LielAmar
reviewed
Jul 6, 2024
src/main/java/com/lielamar/auth/velocity/TwoFactorAuthentication.java
Outdated
Show resolved
Hide resolved
LielAmar
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.7 Update:
For this update, a lot has changed in the codebase.
The plugin will be compiled via Java 17, and should support all versions from 1.8 - 1.21.
The plugin will be generating QR codes now instead of using external services, and the 2FA system will support every auth app.
Changelog: