Sync ActiveMerchant repo #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unts limit Summary: ---------- This PR add the verification of number of external accounts created in stripe and delete accounts to avoid the error of maximum number of accounts exceeded Unit tests execution Finished in 13.744862 seconds. 5010 tests, 74852 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 364.50 tests/s, 5445.82 assertions/s Remote test execution remote_stripe_test.rb Finished in 200.632001 seconds. 74 tests, 339 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.37 tests/s, 1.69 assertions/s remote_stripe_payment_intents_test.rb Finished in 187.727749 seconds. 66 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.35 tests/s, 1.67 assertions/s Running RuboCop... Inspecting 725 files 725 files inspected, no offenses detected RuboCop: 725 files inspected, no offenses detected Closes #4239
Adds the option to pass `skip_radar_rules`, which allows a radar-enabled account to create Charges or Intents without applying any radar screening to the transaction. Also fixes a rubocop error and two date-specific test failures. CE-2234 725 files inspected, no offenses detected 5018 tests, 74825 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_stripe_test 75 tests, 342 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_stripe_payment_intents_test 68 tests, 318 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Added `userPO`, `taxable`, `nationalTaxIndicator`, `taxAmount`, and `nationalTax` in the cyber source implementation. CE-2240 Remote: 101 tests, 520 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.0594% passed Unit: 5020 tests, 74836 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected
CE-2246 Remote: 14 tests, 45 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 16 tests, 104 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local: 5020 tests, 74837 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Closes #4254 Added `redact` method in IPG implementation to delete vaulted payment method. CE-2283 Remote: 17 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 5021 tests, 74840 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected
CE-2276 Remote: 14 tests, 36 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 12 tests, 51 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local: 5020 tests, 74836 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Added `sca_merchant_initiated` field in orbital implementation to support master card eci 7 to exempt from SCA when flag is set. CE-2236 Remote: 77 tests, 349 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 5022 tests, 74849 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected
* GlobalCollect: Update Production Endpoint The production url for Ingenico (Global Collect) is https://world.api-ingenico.com. Currently, Ingenico redirects to the new url but it has been advised that we update the `live_url`. [Ingenico endpoints](https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/endpoints.html?paymentPlatform=ALL) CE-2116 Unit: 31 tests, 154 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 29 tests, 72 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.5517% passed
Closes #4262 Added `unstore` method to redact store token in paytrace implementation along with its remote test. CE-2286 Remote: 27 tests, 69 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 5022 tests, 74849 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected
Closes #4263 Fixed unit test case for gateway id that was sending remote call to gateway in mundipagg implementation. CE-2206 Unit: 5022 tests, 74850 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected Remote: 41 tests, 101 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
This is a PR to add the gateway adapter for Decidir Plus Things to note in this PR: * No auth/capture or void/cancel transactions * Payment Method's must be `stored` and the returned third party token will be used in combination with other card data in subsequent `purchase` and `refund` transactions * The reference token is comprised of the `stored` payment method's `id` (returned from Decidir+) and the `bin` of the payment method, separated by a pipe (`|`) * Authorization is handled by an `apikey` passed into the headers. Either the `public_key` for the tokenization endpoint or `private_key` for the rest * Some fields that are stubbed in with defaults ARE REQUIRED in order for the transaction to be successful (i.e., `purchase` will fail without `sub_payments` array) CE-2145 Unit: 6 tests, 20 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 8 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Maintain default eci of 05 for vts NTs Closes #4235 Remote: 43 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 40 tests, 234 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local: 5034 tests, 74935 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 728 files inspected, no offenses detected
What changed? * Refactored purchase method to pass arguments to other methods that are responsible for appending the `post` hash with data for a `purchase` transaction * `token` and `bin` are parsed from a `payment` of String type instead of a `payment_id` in the `options` hash CE-2145 Unit: 6 tests, 20 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 8 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
-`redact` method changed to `unstore` CE-2285 Remote: 31 tests, 94 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 16 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local: 5034 tests, 74935 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 728 files inspected, no offenses detected
Added `line_items` field to be passed in for authorize method in cyber source implementation. CE-2240 Remote: 101 tests, 520 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.0594% passed Unit: 5023 tests, 74856 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 725 files inspected, no offenses detected Closes #4268
CE-2242 Line 301 in add_auth_purchase_params was causing an extra ssl_token field with a nil value to be added to the request. The changes remove the extra ssl_token, which has eliminated the invalid card errors. I’ve added some logic in the commit method and the authorization_from method to handle the third_party_token coming from the store call. Unit Tests: 47 tests, 243 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests: 39 tests, 176 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.4359% passed test_successful_special_character_encoding_truncation(RemoteElavonTest) is failing currently on master and on my branch. (the remote test results have been a bit inconsistent for me yesterday and today) Local: 5035 tests, 74943 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Some payment gateways require attributes that cannot currently be instantiated with network_tokenization_credit_card. For example - some gateways require deviceManufacturerIdentifer and paymentDataType to be passed in for apple pay which can now be stored in the metadata.
Add `sub_payment` fields to `purchase` transactions. This field needs to be set in the post body, regardless of whether or not it is populated with data. Fix country code for this gateway. CE-2145 Unit: 7 tests, 25 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 9 tests, 30 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Decidir Plus: Sub Payment Fields Add `sub_payment` fields to `purchase` transactions. This field needs to be set in the post body, regardless of whether or not it is populated with data. Fix country code for this gateway. CE-2145 Unit: 7 tests, 25 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 9 tests, 30 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
SUMMARY Added verify with $0 amount into Orbital Gateway Discover card type does'nt support $0.00 auth instead use $1.00 Closes #4275 JIRA TICKET NUMBER GWI-71 UNIT TEST Finished in 0.661291 seconds. ----------------------------------------------------------------------------------------------------------------- 135 tests, 779 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ------------------------------------------------------------------------------------------------------------------ 204.15 tests/s, 1178.00 assertions/s REMOTE TEST Finished in 211.728643 seconds. ----------------------------------------------------------------------------------------------------------------- 80 tests, 355 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ----------------------------------------------------------------------------------------------------------------- 0.38 tests/s, 1.68 assertions/s RUBOCOP 726 files inspected, no offenses detected
* updated Production and test endpoint URLs (old ones are deprecated as of Jan 31st 2022 and just return aywayCode only for gateway_specific_response_field message field * Adds commit from DanAtPayway@b96319f Loaded suite test/remote/gateways/remote_payway_dot_com_test 16 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/unit/gateways/payway_dot_com_test 16 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed bundle exec rake test:local 5038 tests, 74959 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Running RuboCop... 728 files inspected, no offenses detected
Closes #4282 Added `line_items` field to be passed in purchase method also for cyber source implementation. CE-2240 Unit: 5044 tests, 74980 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 728 files inspected, no offenses detected Remote: 101 tests, 520 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.0594% passed
Also fixes an issue in the remote tests that caused intermittent failures. CE-2319 unit 5035 tests, 74943 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed rubocop 728 files inspected, no offenses detected remote Loaded suite test/remote/gateways/remote_global_collect_test 31 tests, 78 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.7742% passed
Added support for `stored_credential` to allow recurring payments of cardholder and merchant in payflow pro implementation. CE-2244 Closes #4277 Remote: 39 tests, 169 assertions, 10 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 74.359% passed Unit: 5036 tests, 74956 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 728 files inspected, no offenses detected
Add support for fraud detection with Decidir Plus. This PR includes a method to add `fraud_detection` fields to the post body of a `purchase` transaction. The `csmdds` subfield of `fraud_detection` is expected to be given as an array of hashes with a `code` and `description` value. CE-2337 Unit: 8 tests, 30 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 10 tests, 33 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
The field names, test values and logic parsing follow the guides available in Moneri's [About 3D Secure 2.0](https://developer.moneris.com/livedemo/3ds2/reference/guide/php) guides. **Caveats** ==== The available magic test data do not make it possible to trigger reliable fail-scenarios for MPI-driven authentications. ECS-1882 --- Test Summary Note: failing tests are same ones as in `master` branch Local: 5125 tests, 75361 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.6683% passed Unit: 53 tests, 284 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 44 tests, 223 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed
… 2 causing a AVS error (#4362) Co-authored-by: Nicholas Ashton <[email protected]>
Local: 5123 tests, 75396 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 739 files inspected, no offenses detected Unit: 114 tests, 554 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 104 tests, 528 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.1538% passed
------ Summary: This PR includes the enhanced data to enable level 2 and 3 data support in this gateway Test Execution: ------- Finished in 37.183788 seconds. 54 tests, 221 assertions, 13 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 75.9259% passed Failing tests are not related to this requirement RuboCop: 736 files inspected, no offenses detected Closes #4360
- To note: the gateway doesn’t support void transactions for card payment methods, they must be run as refunds - The gateway does not accept a refund unless the original transaction has been completed/closed/captured. Due to this, the verify method has to run a purchase and then a refund as opposed to the standard authorize and void - Stylistic refactoring and cleaning up of some redundant code CE-2394 Local: 5127 tests, 75381 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 739 files inspected, no offenses detected Unit: 15 tests, 44 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 19 tests, 51 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Local: 5129 tests, 75429 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 739 files inspected, no offenses detected Unit: 114 tests, 554 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Note: `test_successful_asynchronous_adjust` needs test creds where async adjust is enabled to succeed. Remote: 104 tests, 533 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 99.0385% passed
and `merchant_order_id` CE-2530 Rubocop: 739 files inspected, no offenses detected Unit: 5145 tests, 75476 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote: Loaded suite test/remote/gateways/remote_airwallex_test 18 tests, 46 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
Unit: 16 tests, 96 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 18 tests, 27 assertions, 16 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 11.1111% passed CE-1846
Updated `error_code_from` to respond with default gateway error code in case error is not listed in `STANDARD_ERROR_CODE_MAPPING`. CE-2512 Closes #4381 Remote: 123 tests, 440 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.374% passed Unit: 5146 tests, 75480 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 739 files inspected, no offenses detected
Added support for tandem implementation in orbital and test case coverage. CE-2432 Closes #4376
Added `recipient_street_address`, `recipient_city`, `recipient_province_code`, and `recipient_country_code` fields to pass recipient information for refund operation. CE-2500 Unit: 5148 tests, 75508 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 739 files inspected, no offenses detected Remote: 46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 86.9565% passed Closes #4384
CE-2300 Unit: 28 tests, 105 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 22 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add support to pass `metadata` on `purchase`, `authorize`, and `refund` transactions and `ewallet_id` on `purchase` and `authorize` transactions. `metadata` can contain any collection of data so long as it is a json object. CE-2396 Unit: 16 tests, 47 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 21 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
CE-2491 Rubocop: 739 files inspected, no offenses dtected Unit: 5159 tests, 75564 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_priority_test 27 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passede
Field name change to `pm_type` to be more specific CE-2396 Unit: 16 tests, 47 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 21 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Adds the unusued `options` argument to the `verify` method so that the method accepts two arguments, according to ActiveMerchant standards. Rubocop: 739 files inspected, no offenses detected Unit: 5159 tests, 75564 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_priority_test 27 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Description ------------------------- We need to check if all remote test are passing successfully Updating test cards' year and removing unusual test JIRA ticket number ------------------------- GWI-141 Unit test ------------------------- Finished in 0.011947 seconds. 13 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1088.14 tests/s, 7114.76 assertions/s Remote test ------------------------- Finished in 54.175181 seconds. 15 tests, 56 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.28 tests/s, 1.03 assertions/s Rubocop ------------------------- 739 files inspected, no offenses detected Closes #4386
…tatuses Rubocop: 739 files inspected, no offenses dtected Unit: 5161 tests, 75570 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_priority_test 27 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passede
Summary: This PR updates the url of NMI to the most recent url according to the docs up to date Test Execution: Unit test Finished in 8.867635 seconds. 52 tests, 394 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test Finished in 95.969518 seconds. 49 tests, 178 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 739 files inspected, no offenses detected Closes #4380
CE-2541 There is a bug in the `case` statements where we are attempting to resolve it conditionally with an `||`, but `case` takes a single value or list of values Unit: BluePay: 30 tests, 142 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Paysafe: 16 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 40 tests, 236 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: CheckoutV2: 43 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed BluePay: 19 tests, 90 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Paysafe: 31 tests, 94 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add support for Spreedly's 3DS Global Solution. One notable distinction is that Airwallex only supports three digit 3DS versions. Versions returned from the MPI are formatted to meet that requirement. Ex: 2.0 => 2.0.0 CE-2301 Unit: 31 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 3 unrelated tests failing 25 tests, 56 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88% passed
Add bin ranges so that we can identify the French card brand Cartes Bancaires
The `original_transaction_id` field allows users to manually override the `network_transaction_id`. This is useful when testing MITs using Stored Credentials on Airwallex because they only allow specific values to be passed which they do not return, and would normally be passed automatically in a standard MIT Stored Credentials flow. This PR also cleans up remote and unit tests for Airwallex stored creds. CE-2560 Unit: 33 tests, 176 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ------------------------------ This PR includes the fields and logic required to send external 3ds data in SecurionPay transactions. Test Execution: ------------------------------ Unit test Finished in 0.033598 seconds. 33 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test Finished in 30.68658 seconds. 27 tests, 91 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 81.4815% passed Failures not related with the added code RuboCop: ------------------------------ 739 files inspected, no offenses detected
Airwallex requires specific NTID values in order to test the full Stored Credential flow from CIT auth to MIT purchase. These values are now automatically populated based on card `brand`. This PR also removes the `original_transaction_id` GSF. CE-2593 Unit: 33 tests, 176 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 26 tests, 61 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
CE-2407 This PR does some refactoring and updates some value types that were being passed incorrectly. The scrub method has also been updated. Remote Tests: 12 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: 12 tests, 83 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local Tests: 5167 tests, 75646 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 739 files inspected, no offenses detected
Monei's sandbox does not care if this field gets passed or not, but its omission will cause failures in production. CE-2562 Rubocop: 739 files inspected, no offenses detected Unit: 5174 tests, 75676 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 25 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.