-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse URI queries in to key value pairs #237
Parse URI queries in to key value pairs #237
Conversation
- Adds `queries` dict to request uri object containing the uri queries as key value pairs
cca4b7e
to
3815b38
Compare
@saviorand Here is the PR for the initial query processing changes as it relates to Lightbug-HQ/lightbug_api#9 (comment) |
@izo0x90 wrote a couple unit tests with my friend Claude 😁 |
Nice, Claude 🤖 caught a great missing use case with the encoding here ... I added a todo to make sure we decode those strings. Tests look great to me, so you are good I'm good to merge 🔥 I will look a little into whats out there for decoding url strings in Mojo, if there isn't anything or anything we want to add as a dep. I can potentially work on adding that as utility to lib. |
@izo0x90 makes sense, let's make this a separate PR. Merged! Huge thanks and congrats on the contribution 😀 |
queries
dict to request uri object containing the uri queries as key value pairs