Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse URI queries in to key value pairs #237

Merged

Conversation

izo0x90
Copy link
Contributor

@izo0x90 izo0x90 commented Jan 26, 2025

  • Adds queries dict to request uri object containing the uri queries as key value pairs

- Adds `queries` dict to request uri object containing the uri queries
  as key value pairs
@izo0x90 izo0x90 force-pushed the Hristo/Parse-uri-queris-as-key-vals branch from cca4b7e to 3815b38 Compare January 26, 2025 20:43
@izo0x90
Copy link
Contributor Author

izo0x90 commented Jan 26, 2025

@saviorand Here is the PR for the initial query processing changes as it relates to Lightbug-HQ/lightbug_api#9 (comment)

@saviorand
Copy link
Collaborator

saviorand commented Jan 27, 2025

@izo0x90 wrote a couple unit tests with my friend Claude 😁
Commented out things that don't work yet - but those mostly have to do with decoding. I think for now we can keep these out from this PR and deal with them later.
Let me know when you take a look and if it makes sense, then we can merge

@izo0x90
Copy link
Contributor Author

izo0x90 commented Jan 27, 2025

@izo0x90 wrote a couple unit tests with my friend Claude 😁 Commented out things that don't work yet - but those mostly have to do with decoding. I think for now we can keep these out from this PR and deal with them later. Let me know when you take a look and if it makes sense, then we can merge

Nice, Claude 🤖 caught a great missing use case with the encoding here ... I added a todo to make sure we decode those strings. Tests look great to me, so you are good I'm good to merge 🔥

I will look a little into whats out there for decoding url strings in Mojo, if there isn't anything or anything we want to add as a dep. I can potentially work on adding that as utility to lib.

@saviorand saviorand merged commit 369005e into Lightbug-HQ:main Jan 27, 2025
3 checks passed
@saviorand
Copy link
Collaborator

@izo0x90 makes sense, let's make this a separate PR. Merged! Huge thanks and congrats on the contribution 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants