Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split http module into multiple files #67

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

bgreni
Copy link
Collaborator

@bgreni bgreni commented Sep 27, 2024

Module structure remains the same for users (import paths are the same as before), but request and response have their own files to keep things easier to maintain as their complexity grows.

@saviorand
Copy link
Collaborator

Just pushed , I removed the sys package since it's not needed now that we removed the Python Client/Server implementations

@bgreni
Copy link
Collaborator Author

bgreni commented Oct 23, 2024

@saviorand Just a friendly ping that I recently finally got around to addressing your feedback

@saviorand
Copy link
Collaborator

@bgreni thanks for the ping. Double-checked everything, looking good. Removed a couple print statements. Merging now.

@saviorand saviorand merged commit f10c091 into Lightbug-HQ:main Oct 23, 2024
2 checks passed
@saviorand
Copy link
Collaborator

Thanks for this contribution! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants