Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mutation in server-side service implementation #76

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Allow mutation in server-side service implementation #76

merged 1 commit into from
Dec 5, 2024

Conversation

bgreni
Copy link
Collaborator

@bgreni bgreni commented Nov 30, 2024

Resolves #35

  • Allow mutations in server service struct
  • Apply formatting on recent changes
  • Resolve some lint warnings in the README

@bgreni bgreni force-pushed the allow-service-struct-mutation branch from a108f32 to c49905d Compare November 30, 2024 20:05
@saviorand
Copy link
Collaborator

@bgreni done with the review, looks good, just a couple philosophical points, but we can resolve those later. OK to merge?

@saviorand saviorand merged commit bd58e0d into Lightbug-HQ:main Dec 5, 2024
2 checks passed
@saviorand
Copy link
Collaborator

@bgreni merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saviorand saviorand saviorand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTPService's Self should be mutable to maintain state over incoming requests
2 participants
@bgreni @saviorand