Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recv hanging on chunked transfer #79

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

bgreni
Copy link
Collaborator

@bgreni bgreni commented Dec 30, 2024

Reading bytes could hang if using chunked transfer encoding if the server disconnects. Now check if the last read message ends with the expected zero width chunk.

@saviorand
Copy link
Collaborator

Looks good and the if condition on bytes_recv does seem redundant, so good that we are removing that.
Merging!

@saviorand saviorand merged commit 0ea6472 into Lightbug-HQ:main Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants