Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatML prompt template #1882

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

ysjprojects
Copy link
Contributor

Multiple SOTA models, including the ones currently added to the framework, use the same ChatML template, only differing in terms of system prompts. This PR unifies them into a single "ChatML" PromptStyle class in order to adhere to the DRY principle.

@Andrei-Aksionov
Copy link
Collaborator

Great one.
Thanks 🚀

@Andrei-Aksionov Andrei-Aksionov merged commit 5670d46 into Lightning-AI:main Dec 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants