update PR template (#4523)

* update PR template * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Roger Shieh <[email protected]> * Apply suggestions from code review Co-authored-by: edenlightning <[email protected]> Co-authored-by: chaton <[email protected]> Co-authored-by: Roger Shieh <[email protected]> Co-authored-by: edenlightning <[email protected]>
Lightning-AI · Nov 5, 2020 · 62ea461 · 62ea461
1 parent 51cc7a8
commit 62ea461
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -4,6 +4,8 @@
 Please include a summary of the change and which issue is fixed.
  Please also include relevant motivation and context.
  List any dependencies that are required for this change.
+
+If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
 -->
 
 Fixes # (issue)
@@ -20,10 +22,14 @@ Fixes # (issue)
 <!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->
 
 ## PR review
- - [ ] Is this pull request ready for review? (if not, please submit in draft mode)
+Anyone in the community is free to review the PR once the tests have passed.
+Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:  
 
-Anyone in the community is free to review the PR once the tests have passed.    
-If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
+ - [ ] Is this pull request ready for review? (if not, please submit in draft mode)
+ - [ ] Check that all items from **Before submitting** are resolved
+ - [ ] Make sure the title is self explanatory and the description concisely explains the PR
+ - [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._
+
 
 ## Did you have fun?
 Make sure you had fun coding 🙃