skip test on 3.6 not working

pytorch_lightning/trainer/trainer.py

@@ -745,11 +745,11 @@ def from_argparse_args(cls, args: Union[Namespace, ArgumentParser], **kwargs) ->
             >>> trainer = Trainer.from_argparse_args(args, logger=False)
         """
         if isinstance(args, ArgumentParser):
-            args = Trainer.parse_argparser(args)
+            args = cls.parse_argparser(args)
         params = vars(args)
 
         # we only want to pass in valid Trainer args, the rest may be user specific
-        valid_kwargs = inspect.signature(Trainer).parameters
+        valid_kwargs = inspect.signature(cls.__init__).parameters
         trainer_kwargs = dict((name, params[name]) for name in valid_kwargs if name in params)
         trainer_kwargs.update(**kwargs)
 

tests/trainer/test_trainer_cli.py

@@ -1,5 +1,6 @@
 import inspect
 import pickle
+import sys
 from argparse import ArgumentParser, Namespace
 from unittest import mock
 
@@ -112,6 +113,10 @@ def test_argparse_args_parsing(cli_args, expected):
     assert Trainer.from_argparse_args(args)
 
 
+@pytest.mark.skipif(
+    sys.version_info < (3, 7),
+    reason="signature inspection while mocking is not working in Python < 3.7 despite autospec"
+)
 @pytest.mark.parametrize(['cli_args', 'extra_args'], [
     pytest.param({}, {}),
     pytest.param({'logger': False}, {}),