Rename "master" methods to "main" in ClusterEnvironment plugins #10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
breaking change
for more information, see https://pre-commit.ci
11 tasks
awaelchli
force-pushed
the
refactor/master-to-main
branch
from
bad1ec1 to
77aca7c
Compare
justusschock
approved these changes
Nov 3, 2021
for more information, see https://pre-commit.ci
Co-authored-by: Justus Schock <[email protected]>
…factor/master-to-main
carmocca
approved these changes
Nov 4, 2021
awaelchli
requested review from
Borda,
edenlightning and
kaushikb11
as code owners
awaelchli
requested review from
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
awaelchli
changed the title
Borda
reviewed
Nov 5, 2021
|
To clarify, @Borda the MASTER_* variables in os.environ are set by pytorch and read by pytorch (or rather the distributed backends). We can't rename them, but it's also not a problem because these are not user facing. However, our public API for the cluster plugins is and I think we should update them. Another example was #10105. |
8 tasks
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
…tning-AI#10103) * rename occurrences of master port, master address, maser node, master process * rename properties * add property decorators * occurrences in docs * update changelog * update changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add lost method * create deprecation * add changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo (but it was already there!!!) * Apply suggestions from code review Co-authored-by: Justus Schock <[email protected]> * add todo * update more occurences * add types * add missing import Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Justus Schock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8774
Continues #9094 (repository and branch was deleted)
In addition, converts the
main_portandmain_addressmethods to properties. This was requested in #6303.Does your PR introduce any breaking changes? If yes, please list them.
Yes. User with custom cluster environment plugins won't be able to instantiate their existing plugins due to the requirement of
main_port,main_addressto be abstract. They will have to renamemaster_portandmaster_addressmethods immediately.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)