Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove calls to agg_and_log_metrics #11832

Merged
merged 16 commits into from
Feb 18, 2022
Merged

Deprecate and remove calls to agg_and_log_metrics #11832

merged 16 commits into from
Feb 18, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Feb 10, 2022 •
edited
Loading

What does this PR do?

Deprecates and removes all calls to agg_and_log_metrics in the codebase. @daniellepintz showed here #9145 (comment) that agg_and_log_metrics is a no-op and can safely be removed.

Part of #9145

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akashkw akashkw marked this pull request as ready for review February 10, 2022 00:48
@akashkw akashkw marked this pull request as draft February 10, 2022 00:53
@akashkw akashkw changed the title Remove calls to agg_and_log_metrics Deprecate and remove calls to agg_and_log_metrics Feb 10, 2022
@akashkw akashkw force-pushed the refactor/remove-references-to-agg-and-log_metrics branch from e4cded9 to 210b241 Compare February 10, 2022 03:15
@akashkw akashkw marked this pull request as ready for review February 10, 2022 03:21
daniellepintz
daniellepintz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

ethanwharris
ethanwharris approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ananthsub ananthsub added deprecation Includes a deprecation logger Related to the Loggers labels Feb 10, 2022
@ananthsub ananthsub added this to the 1.6 milestone Feb 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 11, 2022
@akashkw
Copy link
Contributor Author

akashkw commented Feb 11, 2022

are you planning to deprecate these in a separate PR?

https://github.com/PyTorchLightning/pytorch-lightning/blob/1515ef90ee2724bcba46e1434eb4b4f9719ebdd7/pytorch_lightning/loggers/base.py#L65-L66

https://github.com/PyTorchLightning/pytorch-lightning/blob/1515ef90ee2724bcba46e1434eb4b4f9719ebdd7/pytorch_lightning/loggers/base.py#L81-L100

Yep, PR is up now #11871

@akashkw akashkw mentioned this pull request Feb 11, 2022
Merged
12 tasks
tchaton
tchaton approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

rohitgr7
rohitgr7 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
LGTM!

pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
Borda
Borda previously requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp block until @awaelchli checks it, for the context #9145 (comment)

@mergify mergify bot removed the ready PRs ready to be merged label Feb 14, 2022
carmocca
carmocca reviewed Feb 16, 2022
View reviewed changes
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
tests/deprecated_api/test_remove_1-8.py Outdated Show resolved Hide resolved
tests/deprecated_api/test_remove_1-8.py Outdated Show resolved Hide resolved
@daniellepintz
Copy link
Contributor

@awaelchli @Borda can we unblock merging this?

@awaelchli awaelchli dismissed Borda’s stale review February 18, 2022 02:15

dismiss because block was because of me and my concerns were discussed

@mergify mergify bot added the ready PRs ready to be merged label Feb 18, 2022
awaelchli
awaelchli reviewed Feb 18, 2022
View reviewed changes
tests/deprecated_api/test_remove_1-8.py Outdated Show resolved Hide resolved
tests/deprecated_api/test_remove_1-8.py Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) February 18, 2022 02:16
@awaelchli awaelchli merged commit d613719 into Lightning-AI:master Feb 18, 2022
carmocca pushed a commit that referenced this pull request Feb 18, 2022
@akashkw @pre-commit-ci
@awaelchli @carmocca
Deprecate and remove calls to agg_and_log_metrics (#11832)
13a9112 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <[email protected]>
@akashkw akashkw deleted the refactor/remove-references-to-agg-and-log_metrics branch February 18, 2022 19:32
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
12 tasks
@Borda Borda changed the title Deprecate and remove calls to agg_and_log_metrics Deprecate and remove calls to agg_and_log_metrics Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca left review comments

@daniellepintz daniellepintz daniellepintz approved these changes

@ananthsub ananthsub ananthsub approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Borda left review comments

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@edward-io edward-io Awaiting requested review from edward-io

Assignees
No one assigned
Labels
deprecation Includes a deprecation logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
9 participants
@akashkw @daniellepintz @ananthsub @awaelchli @Borda @ethanwharris @carmocca @tchaton @rohitgr7