Change min max gpu memory to be on their own plots #1358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
The original min_max gpu memory functionality has unexpected behavior where the min and max memory is plotted in the gpu_{gpu_index} plot. This doesn't make sense when the min and max gpu usage switches between GPUs during training as the plot is uninterpretable. It's also a waste of space having a gpu_{gpu_index} plot for each master node gpu when only the gpus that have the max and min memory have data points.
This PR changes the logger to have two plots: "min_gpu_mem", "max_gpu_mem", which contain the min and max gpu memory plots respectively.