Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neptune online #1499

Merged
merged 1 commit into from
Apr 15, 2020
Merged

neptune online #1499

merged 1 commit into from
Apr 15, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 15, 2020

What does this PR do?

Fixes #1459 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Apr 15, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 15, 2020
@mergify mergify bot requested a review from a team April 15, 2020 12:59
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1499 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1499   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          67      67           
  Lines        3753    3753           
======================================
  Hits         3407    3407           
  Misses        346     346           

@williamFalcon williamFalcon merged commit 8322f1b into master Apr 15, 2020
@pitercl
Copy link
Contributor

pitercl commented Apr 15, 2020

Thank you @Borda, @williamFalcon for the super quick reaction :)

@Borda Borda deleted the issue/neptune branch April 15, 2020 15:34
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants