Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a small issue in trainer logging #1563

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

guydav
Copy link
Contributor

@guydav guydav commented Apr 22, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs? No changes required
  • Did you write any new necessary tests? I don't think this requires any new tests, does it?
  • If you made a notable change (that affects users), did you update the CHANGELOG? Should this be on the changelog?

What does this PR do?

Fixes half of #1520. This is the simpler half, where the epoch is logged into a dict that isn't passed to the loggers.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

As much as can be in a one-line fix.

@mergify mergify bot requested a review from a team April 22, 2020 17:02
@guydav
Copy link
Contributor Author

guydav commented Apr 22, 2020

Unsurprisingly, this broke the logging tests, probably since the epoch field now appears in the dictionary that arrives in the logger. Can I get approval to change the tests to account for this new field?

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, LGTM 🤖

@Borda Borda added the bug Something isn't working label Apr 23, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 23, 2020
@Borda Borda added the ready PRs ready to be merged label Apr 23, 2020
@mergify mergify bot requested a review from a team April 23, 2020 11:31
@guydav
Copy link
Contributor Author

guydav commented Apr 23, 2020

I added the change to the tests. Let's see that everything passes now.

Two questions:

  1. Do you merge directly to master? Or is there a develop or some other branch that this should be merged into?
  2. Is this (the epoch field arriving properly to the loggers) a change that should be documented anywhere?

@williamFalcon
Copy link
Contributor

  1. yes
  2. i don't think so right now? maybe if people bring it up but it seems like intuitive default behavior.

@guydav
Copy link
Contributor Author

guydav commented Apr 23, 2020

Okay cool. The only test that's failing is the PyTorch-v1_5 one that timed out. Does that make sense? As far as I'm concerned it's ready to merge, but if there's a way to return this test, that might be even better.

@Borda
Copy link
Member

Borda commented Apr 23, 2020

@guydav rebased

@williamFalcon williamFalcon merged commit fe2b666 into Lightning-AI:master Apr 23, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants