Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete test for batch size < num gpus #1705

Merged
merged 1 commit into from
May 5, 2020
Merged

Complete test for batch size < num gpus #1705

merged 1 commit into from
May 5, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 2, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Follow up to #1609
Uses the new TemplateModel for testing.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team May 2, 2020 17:08
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #1705 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1705   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        4151    4151           
======================================
  Hits         3661    3661           
  Misses        490     490           

@Borda Borda added the ci Continuous Integration label May 3, 2020
@mergify
Copy link
Contributor

mergify bot commented May 5, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon merged commit 2b03d34 into Lightning-AI:master May 5, 2020
@awaelchli awaelchli deleted the bugfix/reduce_batch_followup branch May 5, 2020 18:09
@Borda Borda added this to the 0.7.6 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants