-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModelCheckpoint.CHECKPOINT_NAME_LAST
test interaction
#18993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Nov 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18993 +/- ##
==========================================
- Coverage 76% 48% -27%
==========================================
Files 450 442 -8
Lines 36460 36307 -153
==========================================
- Hits 27563 17507 -10056
- Misses 8897 18800 +9903 |
carmocca
approved these changes
Nov 12, 2023
Merged
Borda
pushed a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit b4605b4)
lantiga
pushed a commit
that referenced
this pull request
Nov 15, 2023
(cherry picked from commit b4605b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a test interaction seen in the master branch. The class attribute is set in one test, and then reset at the end of the test. In case this test fails for some reason, the patched attribute
ModelCheckpoint.CHECKPOINT_NAME_LAST
would carry over into other tests, causing them to fail since the checkpoint name assertion expects a different "last" name.📚 Documentation preview 📚: https://pytorch-lightning--18993.org.readthedocs.build/en/18993/
cc @carmocca @awaelchli @Borda