Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cancel-in-progress if PR #19204

Merged
merged 3 commits into from
Dec 21, 2023
Merged

ci: cancel-in-progress if PR #19204

merged 3 commits into from
Dec 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 21, 2023

What does this PR do?

let's hold merging of all PRs until we resolve a big leak

image

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19204.org.readthedocs.build/en/19204/

@github-actions github-actions bot added docs Documentation related ci Continuous Integration dockers package labels Dec 21, 2023
Copy link
Contributor

github-actions bot commented Dec 21, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.12, oldest) failure
pl-cpu (macOS-11, lightning, 3.9, 1.12) failure
pl-cpu (macOS-11, lightning, 3.10, 1.13) failure
pl-cpu (macOS-11, lightning, 3.10, 2.0) failure
pl-cpu (macOS-11, lightning, 3.10, 2.1) failure
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest) failure
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) failure
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) failure
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) failure
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) failure
pl-cpu (windows-2022, lightning, 3.8, 1.12, oldest) failure
pl-cpu (windows-2022, lightning, 3.9, 1.12) failure
pl-cpu (windows-2022, lightning, 3.10, 1.13) failure
pl-cpu (windows-2022, lightning, 3.10, 2.0) failure
pl-cpu (windows-2022, lightning, 3.10, 2.1) failure
pl-cpu (macOS-11, pytorch, 3.8, 1.13) failure
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) failure
pl-cpu (windows-2022, pytorch, 3.8, 1.13) failure
pl-cpu (macOS-12, pytorch, 3.11, 2.0) failure
pl-cpu (macOS-12, pytorch, 3.11, 2.1) failure
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) failure
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) failure
pl-cpu (windows-2022, pytorch, 3.11, 2.0) failure
pl-cpu (windows-2022, pytorch, 3.11, 2.1) failure

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🟡 pytorch-lightning: TPU workflow
Check ID Status
test-on-tpus (pytorch, xrt, v4-8) no_status
test-on-tpus (pytorch, pjrt, v4-8) no_status

These checks are required after the changes to .github/workflows/tpu-tests.yml.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.12, 11.7.1) success
build-cuda (3.9, 1.13, 11.8.0) success
build-cuda (3.9, 1.13, 12.0.1) success
build-cuda (3.10, 2.0, 11.8.0) success
build-cuda (3.10, 2.1, 12.1.0) success
build-pl (3.9, 1.12, 11.7.1) success
build-pl (3.9, 1.13, 11.8.0) success
build-pl (3.9, 1.13, 12.0.1) success
build-pl (3.10, 2.0, 11.8.0) success
build-pl (3.10, 2.1, 12.1.0) success

These checks are required after the changes to .github/workflows/docker-build.yml.

🔴 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) failure
data-cpu (windows-2022, lightning, 3.10, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-data.yml.

🔴 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.12, oldest) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.8, 1.12, oldest) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) failure
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🟡 lightning_fabric: TPU workflow
Check ID Status
test-on-tpus (fabric, xrt, v4-8) no_status
test-on-tpus (pytorch, pjrt, v4-8) no_status

These checks are required after the changes to .github/workflows/tpu-tests.yml.

🔴 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) failure
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (macOS-12, app, 3.11, latest) failure
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (ubuntu-22.04, app, 3.11, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.11, latest) success

These checks are required after the changes to .github/workflows/ci-tests-app.yml.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to .github/workflows/ci-examples-app.yml.

🟢 lightning: Store
Check ID Status
store-cpu (macOS-11, lightning, 3.10, 2.0) success
store-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
store-cpu (windows-2022, lightning, 3.10, 2.0) success

These checks are required after the changes to .github/workflows/ci-tests-store.yml.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success
docs-make (app, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .github/workflows/code-checks.yml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to .github/workflows/ci-pkg-install.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #19204 (1e10a36) into master (02ad844) will decrease coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19204   +/-   ##
=======================================
- Coverage      58%      58%   -0%     
=======================================
  Files         442      442           
  Lines       37251    37251           
=======================================
- Hits        21661    21642   -19     
- Misses      15590    15609   +19     

@Borda Borda requested review from lantiga and awaelchli December 21, 2023 22:08
@Borda
Copy link
Member Author

Borda commented Dec 21, 2023

canceling seems to work correctly - being canceled as this is a PR and I updated from master

@lantiga lantiga merged commit 6ea0e2d into master Dec 21, 2023
@lantiga lantiga deleted the ci/cancel-in-progress branch December 21, 2023 22:49
@Borda Borda added this to the 2.1.x milestone Jan 30, 2024
awaelchli pushed a commit that referenced this pull request Jan 31, 2024
awaelchli pushed a commit that referenced this pull request Jan 31, 2024
lexierule pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dockers docs Documentation related package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants