[WIP] Use torch 2.2 distributed checkpoint APIs for FSDP #19497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
force-pushed
the
carmocca/new-fsdp-ckpt-apis
branch
from
97469de to
fb62091
Compare
carmocca
force-pushed
the
carmocca/new-fsdp-ckpt-apis
branch
from
fb62091 to
bf021fe
Compare
carmocca
commented
Feb 19, 2024
| if _TORCH_GREATER_EQUAL_2_2: | ||
| from torch.distributed.checkpoint.state_dict import StateDictOptions, set_model_state_dict | ||
|
|
||
| # `cpu_offload` disabled because when used with `full_state_dict` only rank 0 loads the state dict |
There was a problem hiding this comment.
Notice that the other path sets rank0_only=False. I asked if this could be configurable in pytorch/pytorch#112837 (comment)
| @@ -440,6 +439,7 @@ def save_checkpoint( | |||
| ) | |||
| if filter is not None and self._state_dict_type == "sharded": | |||
| # https://github.com/pytorch/pytorch/issues/105379 | |||
| # FIXME: revisit support with new APIs | |||
There was a problem hiding this comment.
Reminder to myself
for more information, see https://pre-commit.ci
|
Closing since the new model parallel strategy is most likely the future. Implemented in #19852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #19462
Resources
TODO:
_TORCH_GREATER_EQUAL_2_2 = Falsesince CI only tests 2.2📚 Documentation preview 📚: https://pytorch-lightning--19497.org.readthedocs.build/en/19497/