Destroy process group in atexit handler #19931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
awaelchli
requested review from
lantiga,
Borda,
tchaton and
justusschock
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19931 +/- ##
=========================================
- Coverage 84% 59% -25%
=========================================
Files 426 421 -5
Lines 35258 35166 -92
=========================================
- Hits 29600 20762 -8838
- Misses 5658 14404 +8746 |
Borda
approved these changes
Jun 2, 2024
for more information, see https://pre-commit.ci
awaelchli
force-pushed
the
feature/destroy-pg
branch
from
06d0ec9 to
c751e2d
Compare
lantiga
approved these changes
Jun 5, 2024
awaelchli
force-pushed
the
feature/destroy-pg
branch
from
f2b4001 to
0f68728
Compare
awaelchli
force-pushed
the
feature/destroy-pg
branch
from
87efe08 to
c22c492
Compare
awaelchli
force-pushed
the
feature/destroy-pg
branch
from
c22c492 to
5ce7086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PyTorch 2.4 added a warning if you don't explicitly call
torch.distributed.destroy_process_group()at the end of your program:This will become annoying to users of Lightning because in the vast majority of cases it's completely harmless. The warning is emitted from the C module, so it can't be suppressed via Python. In the spirit of Lightning and making code agnostic to strategy/accelerator, we don't want users to have to make this call manually and remember it every time.
In this PR, I propose to register the destruction in atexit so it runs every time the program exits normally.
📚 Documentation preview 📚: https://pytorch-lightning--19931.org.readthedocs.build/en/19931/
cc @Borda @carmocca @justusschock @awaelchli