Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twine to 6.0.1 for Python 3.13 #20570

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

lantiga
Copy link
Collaborator

@lantiga lantiga commented Feb 3, 2025

What does this PR do?

Python 3.13 removed cgi from its modules, twine 4.0.1 depended on it, which broke CI for 3.13.

This PR upgrades twine to 6.0.1 which dropped its dependence on cgi.


📚 Documentation preview 📚: https://pytorch-lightning--20570.org.readthedocs.build/en/20570/

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/ci.txt.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.9) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.9) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.9) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-14, fabric, 3.9) success
install-pkg (macOS-14, fabric, 3.11) success
install-pkg (macOS-14, pytorch, 3.9) success
install-pkg (macOS-14, pytorch, 3.11) success
install-pkg (macOS-14, lightning, 3.9) success
install-pkg (macOS-14, lightning, 3.11) success
install-pkg (macOS-14, notset, 3.9) success
install-pkg (macOS-14, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.9) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.9) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.9) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.9) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to requirements/ci.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (a944e77) to head (f8fadce).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #20570    +/-   ##
========================================
- Coverage      88%      87%    -1%     
========================================
  Files         267      267            
  Lines       23380    23380            
========================================
- Hits        20481    20235   -246     
- Misses       2899     3145   +246     

@lantiga lantiga merged commit 711abb4 into master Feb 3, 2025
121 of 122 checks passed
@lantiga lantiga deleted the luca/update-twine-6.0.1 branch February 3, 2025 22:40
Borda pushed a commit that referenced this pull request Feb 14, 2025
* Update twine to 6.0.1 for Python 3.13

* Pin pkginfo

* Go with twine 6.0.1

(cherry picked from commit 711abb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants