Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back the slow spawn ddp implementation that people want #2115

Merged
merged 28 commits into from
Jun 8, 2020
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
27b7d8d
training batch clean up
williamFalcon Jun 8, 2020
d210d19
training batch clean up
williamFalcon Jun 8, 2020
3b57580
training batch clean up
williamFalcon Jun 8, 2020
9c69793
training batch clean up
williamFalcon Jun 8, 2020
32f7e26
training batch clean up
williamFalcon Jun 8, 2020
fca185f
training batch clean up
williamFalcon Jun 8, 2020
a7fb179
training batch clean up
williamFalcon Jun 8, 2020
40f7d0a
training batch clean up
williamFalcon Jun 8, 2020
24c905e
training batch clean up
williamFalcon Jun 8, 2020
6962d2e
training batch clean up
williamFalcon Jun 8, 2020
7e36504
training batch clean up
williamFalcon Jun 8, 2020
8d08b4d
training batch clean up
williamFalcon Jun 8, 2020
3f81631
training batch clean up
williamFalcon Jun 8, 2020
661bfa3
training batch clean up
williamFalcon Jun 8, 2020
4a7f4fa
training batch clean up
williamFalcon Jun 8, 2020
ae7ffee
training batch clean up
williamFalcon Jun 8, 2020
aa78f87
training batch clean up
williamFalcon Jun 8, 2020
a352478
training batch clean up
williamFalcon Jun 8, 2020
8368b03
training batch clean up
williamFalcon Jun 8, 2020
6fde56a
training batch clean up
williamFalcon Jun 8, 2020
77a442e
adding spawn
williamFalcon Jun 8, 2020
7256e27
adding spawn
williamFalcon Jun 8, 2020
26d7e9e
adding spawn
williamFalcon Jun 8, 2020
34954e7
adding spawn
williamFalcon Jun 8, 2020
6d285eb
adding spawn
williamFalcon Jun 8, 2020
c890a70
adding spawn
williamFalcon Jun 8, 2020
0f97fe0
adding spawn
williamFalcon Jun 8, 2020
cf1de18
adding spawn
williamFalcon Jun 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
training batch clean up
williamFalcon committed Jun 8, 2020
commit 3b57580d47456a22046533ccdc783bc60959322a
2 changes: 1 addition & 1 deletion pytorch_lightning/trainer/distrib_data_parallel.py
Original file line number Diff line number Diff line change
@@ -457,7 +457,7 @@ def ddp_train(self, process_idx, model, is_master=False, proc_offset=0):
self.reinit_scheduler_properties(self.optimizers, self.lr_schedulers)

# DDP2 uses all GPUs on the machine
if self.distributed_backend == 'ddp':
if self.distributed_backend == 'ddp' or self.distributed_backend == 'ddp_spawn':
device_ids = [self.root_gpu]
elif self.use_ddp2:
device_ids = self.data_parallel_device_ids
2 changes: 1 addition & 1 deletion pytorch_lightning/trainer/trainer.py
Original file line number Diff line number Diff line change
@@ -246,7 +246,7 @@ def __init__(

Use `row_log_interval` instead. Will remove 0.9.0.

distributed_backend: The distributed backend to use.
distributed_backend: The distributed backend to use (dp, ddp, ddp2, ddp_spawn)

use_amp:
.. warning:: .. deprecated:: 0.7.0