Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template #4523

Merged
merged 5 commits into from
Nov 5, 2020
Merged

update PR template #4523

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b9d27a
update PR template
Borda Nov 4, 2020
3eeea06
Update .github/PULL_REQUEST_TEMPLATE.md
tchaton Nov 5, 2020
0c890b8
Merge branch 'master' into docs/PR-template
tchaton Nov 5, 2020
785af4e
Apply suggestions from code review
Borda Nov 5, 2020
fb60a0f
Merge branch 'master' into docs/PR-template
Borda Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
-->

Fixes # (issue)
Expand All @@ -20,10 +22,14 @@ Fixes # (issue)
<!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->

## PR review
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._


## Did you have fun?
Make sure you had fun coding 🙃