-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dockers] install nvidia-dali-cudaXXX #4532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4532 +/- ##
======================================
Coverage 93% 93%
======================================
Files 116 116
Lines 8833 8833
======================================
Hits 8232 8232
Misses 601 601 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we install it from source rather?
ok, I have tried to install specific versions according to CUDA version, but it seems to fail as they have 100 or 110 only... |
@Borda I've tested their cuda 100 version with cuda 10.2, does it make a difference? I think dali-cuda100 should work for both |
I would use the compiled one in Drone config and here rather build for a specific version as we also do for APEx now |
Ok cool, let's see how this works! |
@ydcjeff I got it up to some strange errors with parsing, mind have a look?
|
@Borda @SeanNaren Not sure what you think? |
I spend some time yesterday a few hours trying to compile it... |
I agree with binaries, I even think that this is something that should be rigorously tested as it is a third party library required for users. I wouldn't spend too much time thinking about building from source and just either moving with the binary, or just skipping the test. |
@SeanNaren @ydcjeff reverted to binaries :] |
* [dockers] install nvidia-dali-cuda100 * Apply suggestions from code review * build DALI * build DALI * build DALI * dali from source * dali from source * use binaries * qq Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Sean Naren <[email protected]>
What does this PR do?
Fixes dali installation for #3721
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃