Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: freeze mypy #5634

Merged
merged 6 commits into from
Jan 25, 2021
Merged

fix: freeze mypy #5634

merged 6 commits into from
Jan 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 23, 2021

What does this PR do?

it seems that some newer version (recien=t update from 0.790 to 0.800) of mypy has a different interpretation of skip
the case is that the data/horovod files are in a folder without __init__ so they are not treated as a package so past setting does not have apply fully:

[mypy-tests.*]
ignore_errors = True

until there is resolution in python/mypy#8309 and python/mypy#4675, we freeze 0.790

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Jan 23, 2021
@Borda Borda added this to the 1.2 milestone Jan 23, 2021
@Borda Borda self-assigned this Jan 23, 2021
@Borda Borda added the priority: 1 Medium priority task label Jan 23, 2021
@Borda Borda changed the title fix: update mypy fix: freeze mypy Jan 23, 2021
@Borda Borda marked this pull request as ready for review January 23, 2021 23:28
@Borda Borda enabled auto-merge (squash) January 23, 2021 23:33
@Borda Borda added the ready PRs ready to be merged label Jan 24, 2021
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #5634 (8a8d3fd) into release/1.2-dev (f0fafa2) will increase coverage by 4%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5634    +/-   ##
================================================
+ Coverage               89%     92%    +4%     
================================================
  Files                  153     153            
  Lines                10845   10845            
================================================
+ Hits                  9633   10022   +389     
+ Misses                1212     823   -389     

@Borda Borda merged commit cb58fde into release/1.2-dev Jan 25, 2021
@Borda Borda deleted the fix/update-mypy branch January 25, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants