-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: freeze mypy #5634
Merged
Merged
fix: freeze mypy #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
January 23, 2021 23:28
Borda
requested review from
ananyahjha93,
carmocca,
rohitgr7,
s-rog and
SkafteNicki
January 23, 2021 23:29
12 tasks
ydcjeff
approved these changes
Jan 24, 2021
akihironitta
approved these changes
Jan 24, 2021
tchaton
approved these changes
Jan 24, 2021
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5634 +/- ##
================================================
+ Coverage 89% 92% +4%
================================================
Files 153 153
Lines 10845 10845
================================================
+ Hits 9633 10022 +389
+ Misses 1212 823 -389 |
rohitgr7
approved these changes
Jan 24, 2021
carmocca
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it seems that some newer version (recien=t update from 0.790 to 0.800) of
mypy
has a different interpretation of skipthe case is that the data/horovod files are in a folder without
__init__
so they are not treated as a package so past setting does not have apply fully:until there is resolution in python/mypy#8309 and python/mypy#4675, we freeze 0.790
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃