Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Improve TPU CI #6078

Merged
merged 60 commits into from
Jul 19, 2021
Merged

[Feat] Improve TPU CI #6078

merged 60 commits into from
Jul 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 19, 2021

What does this PR do?

This PR modify the TPU CI to rely on docker hub PyTorch Lightning xla-image,
saving around 4 min, bringing CI time from 12-13 min to 8-9min

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6078 (c596123) into master (257fabd) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6078    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         217     217            
  Lines       14097   14226   +129     
=======================================
+ Hits        13004   13131   +127     
- Misses       1093    1095     +2     

@kaushikb11 kaushikb11 added ci Continuous Integration accelerator: tpu Tensor Processing Unit labels Jul 19, 2021
Copy link
Contributor Author

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.circleci/config.yml Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2021
@mergify mergify bot requested a review from a team July 19, 2021 12:12
.circleci/config.yml Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 19, 2021 12:17
@carmocca carmocca requested a review from Borda July 19, 2021 12:52
@mergify mergify bot requested a review from a team July 19, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants