DeepSpeed Infinity Update #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
added
distributed
SeanNaren
requested review from
awaelchli,
justusschock and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7234 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 203 203
Lines 13137 13157 +20
======================================
- Hits 12023 12005 -18
- Misses 1114 1152 +38 |
|
Should've made this draft since we can't merge this yet |
added 2 commits
April 27, 2021 17:55
tchaton
reviewed
Apr 28, 2021
carmocca
reviewed
Apr 28, 2021
|
After some debugging, fix for the latest DeepSpeed CI here: deepspeedai/DeepSpeed#1026 We'll need a new version to be added to support this, so might be a while before we can merge this PR. I can refer in the documentation to the PR and get this working, so people can test it out :) |
Co-authored-by: Carlos Mocholí <[email protected]>
# Conflicts: # .azure-pipelines/gpu-tests.yml # pytorch_lightning/plugins/training_type/deepspeed.py
added 2 commits
June 14, 2021 10:07
# Conflicts: # pytorch_lightning/plugins/training_type/deepspeed.py
11 tasks
added 2 commits
June 14, 2021 14:03
SeanNaren
requested review from
Borda,
kaushikb11 and
williamFalcon
as code owners
carmocca
approved these changes
Jun 14, 2021
kaushikb11
approved these changes
Jun 14, 2021
kaushikb11
reviewed
Jun 14, 2021
ethanwharris
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the API to the latest changes in DeepSpeed + exposes parameters required for using NVMe Offloading.
This hard requires the latest DeepSpeed, however considering that this is still experimental and changes here are future proofing, I think this is fine.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃