Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename trainer._launch to trainer._run #7265

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 29, 2021

What does this PR do?

launch might be associated w/ distributed launch or process launch which isn't the case here

cc @carmocca
Fixes #7232 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #7265 (80a2a3c) into master (e272bea) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7265   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         199     199           
  Lines       12799   12799           
======================================
- Hits        11170   11168    -2     
- Misses       1629    1631    +2     

@carmocca carmocca added ready PRs ready to be merged refactor labels Apr 29, 2021
@carmocca carmocca added this to the v1.3 milestone Apr 29, 2021
@carmocca carmocca changed the title Rename trainer._launch to trainer._run Rename trainer._launch to trainer._run Apr 29, 2021
@ananthsub ananthsub enabled auto-merge (squash) April 29, 2021 16:23
@ananthsub
Copy link
Contributor Author

ananthsub commented Apr 29, 2021

@tchaton mind taking a look?

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ananthsub ananthsub merged commit 969e857 into Lightning-AI:master Apr 30, 2021
@ananthsub ananthsub deleted the rename-launch branch April 30, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants