Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] re-setup optimizers and model after restore #7578

Closed
wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 17, 2021

What does this PR do?

Fixes #7535

Random, to check which tests don't pass.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title re-setup optimizers and model after restore [wip] re-setup optimizers and model after restore May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #7578 (7c26290) into master (f4f51e0) will increase coverage by 44%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #7578     +/-   ##
========================================
+ Coverage      44%     88%    +44%     
========================================
  Files         197     197             
  Lines       12865   12879     +14     
========================================
+ Hits         5649   11305   +5656     
+ Misses       7216    1574   -5642     

@awaelchli awaelchli closed this May 20, 2021
@Borda Borda deleted the bugfix/resume-fp16_2 branch June 17, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]Resuming From Checkpoint for FP16 failure (Single GPU)
1 participant