Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor on_gpu handling in checkpoint connector #7860

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Part of #7652

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added ready PRs ready to be merged refactor labels Jun 7, 2021
@awaelchli awaelchli modified the milestones: v1.3.x, v1.4 Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #7860 (d83a2c9) into master (009e05d) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7860    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         202     202            
  Lines       13054   13054            
=======================================
- Hits        12088   11461   -627     
- Misses        966    1593   +627     

@awaelchli awaelchli changed the title refactor on_gpu handling for checkpoint connector refactor on_gpu handling in checkpoint connector Jun 7, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! The private attribute looks a bit odd tough: self.trainer._device_type

@awaelchli awaelchli enabled auto-merge (squash) June 7, 2021 08:55
@awaelchli awaelchli merged commit 8c32bf2 into master Jun 7, 2021
@awaelchli awaelchli deleted the feature/resume-4 branch June 7, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants